Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3375)

Issue 6873052: Pull SkMergeImageFilter out into its own file. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by Stephen White
Modified:
11 years, 6 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Pull SkMergeImageFilter out into its own file. Committed: https://code.google.com/p/skia/source/detail?r=6662

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -318 lines) Patch
M gm/imagefiltersgraph.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/testimagefilters.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/effects.gypi View 1 chunk +2 lines, -1 line 0 comments Download
A include/effects/SkMergeImageFilter.h View 1 chunk +46 lines, -0 lines 2 comments Download
M include/effects/SkTestImageFilters.h View 1 chunk +0 lines, -34 lines 0 comments Download
A + src/effects/SkMergeImageFilter.cpp View 3 chunks +10 lines, -128 lines 2 comments Download
M src/effects/SkTestImageFilters.cpp View 1 chunk +0 lines, -154 lines 2 comments Download
M src/ports/SkGlobalInitialization_default.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
Stephen White
PTAL
11 years, 6 months ago (2012-12-04 02:44:53 UTC) #1
robertphillips
Is there a missing file somewhere? https://codereview.appspot.com/6873052/diff/1/include/effects/SkMergeImageFilter.h File include/effects/SkMergeImageFilter.h (right): https://codereview.appspot.com/6873052/diff/1/include/effects/SkMergeImageFilter.h#newcode34 include/effects/SkMergeImageFilter.h:34: uint8_t* fModes; // ...
11 years, 6 months ago (2012-12-04 12:41:29 UTC) #2
Stephen White
https://codereview.appspot.com/6873052/diff/1/include/effects/SkMergeImageFilter.h File include/effects/SkMergeImageFilter.h (right): https://codereview.appspot.com/6873052/diff/1/include/effects/SkMergeImageFilter.h#newcode34 include/effects/SkMergeImageFilter.h:34: uint8_t* fModes; // SkXfermode::Mode On 2012/12/04 12:41:29, robertphillips wrote: ...
11 years, 6 months ago (2012-12-04 14:14:03 UTC) #3
robertphillips
11 years, 6 months ago (2012-12-04 14:15:05 UTC) #4
Okay - I figured it was something like that.

LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b