Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(876)

Issue 6873050: Handle recording a bitmap if copy fails. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 6 months ago by Leon
Modified:
11 years, 6 months ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Handle recording a bitmap if copy fails. If SkBitmapHeap::insert() returns INVALID_SLOT, assert at picture record time so we can debug, but allow it to continue in release mode, so that we can still capture a picture. At playback time, print a message so we know that there was an error. Committed: https://code.google.com/p/skia/source/detail?r=6664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -3 lines) Patch
M src/core/SkPicturePlayback.h View 2 chunks +9 lines, -1 line 0 comments Download
M src/core/SkPictureRecord.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M tests/PictureTest.cpp View 2 chunks +20 lines, -1 line 0 comments Download

Messages

Total messages: 2
Leon
11 years, 6 months ago (2012-12-03 23:03:43 UTC) #1
DerekS
11 years, 6 months ago (2012-12-04 04:10:55 UTC) #2
lgtm.  Thanks for taking care of this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b