Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1775)

Issue 6872056: Add SkMatrix44 constructor that allows user to control the initialization (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by shawnsingh
Modified:
12 years ago
Reviewers:
jamesr, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add SkMatrix44 constructor that allows user to control the initialization method. Preliminary results using Chromium's cc_perftests show that we can avoid almost half of the default constructors from redundantly/unnecessarily initializing the matrix to identity. Committed: https://code.google.com/p/skia/source/detail?r=6742

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M include/utils/SkMatrix44.h View 1 1 chunk +11 lines, -0 lines 0 comments Download
M tests/Matrix44Test.cpp View 1 2 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 5
shawnsingh
PTAL - I'm new to skia land, so please feel free to nitpick as much ...
12 years ago (2012-12-04 05:29:25 UTC) #1
reed1
Perhaps we can make it easier for the compiler to totally ignore the constructor in ...
12 years ago (2012-12-05 14:18:28 UTC) #2
shawnsingh
OK, cool. I like that idea a lot; I'll write the implementation and tests and ...
12 years ago (2012-12-05 18:23:50 UTC) #3
shawnsingh
PTAL - New version with different enum per initialization type. At this time, the kUnititialized_Constructor ...
12 years ago (2012-12-08 00:15:27 UTC) #4
reed1
12 years ago (2012-12-10 13:53:01 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b