Issue 6870050: Insert in middle of SkTInternalLList and SkTLList, SkTLList in-place cons.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6870050: Insert in middle of SkTInternalLList and SkTLList, SkTLList in-place cons. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Insert in middle of SkTInternalLList and SkTLList, in place cons for SkTLList. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6649

Patch Set 3 : #

Total comments: 4

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+237 lines, -7 lines)			Patch
M	include/core/SkTInternalLList.h	View	1 2	2 chunks	+68 lines, -0 lines	2 comments	Download
M	src/core/SkTLList.h	View		7 chunks	+80 lines, -2 lines	0 comments	Download
M	tests/LListTest.cpp	View	1	3 chunks	+89 lines, -5 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM + 2 suggestions https://codereview.appspot.com/6870050/diff/3001/include/core/SkTInternalLList.h File include/core/SkTInternalLList.h (right): https://codereview.appspot.com/6870050/diff/3001/include/core/SkTInternalLList.h#newcode236 include/core/SkTInternalLList.h:236: } I'm surprised this isn't ...

12 years, 1 month ago (2012-12-03 18:56:52 UTC) #2

bsalomon

12 years, 1 month ago (2012-12-03 19:05:25 UTC) #3

https://codereview.appspot.com/6870050/diff/3001/include/core/SkTInternalLList.h
File include/core/SkTInternalLList.h (right):

https://codereview.appspot.com/6870050/diff/3001/include/core/SkTInternalLLis...
include/core/SkTInternalLList.h:236: }
On 2012/12/03 18:56:52, robertphillips wrote:
> I'm surprised this isn't symmetric:
> if (NULL == item->fNext) {
>    SkASSERT(fTail == item);
> } else {
>    SkASSERT(item->fNext->fPrev == item);
> }

Done.

https://codereview.appspot.com/6870050/diff/3001/tests/LListTest.cpp
File tests/LListTest.cpp (right):

https://codereview.appspot.com/6870050/diff/3001/tests/LListTest.cpp#newcode237
tests/LListTest.cpp:237: 
On 2012/12/03 18:56:52, robertphillips wrote:
> NULL != here and in next 3 locations?

Done.

Expand All Messages | Collapse All Messages