Adding a new skia_warnings_as_errors variable.

The goal is to make the ClangCompile buildstep in the Housekeeping bot turn red if there is a warning.
Committed: https://code.google.com/p/skia/source/detail?r=6674

[rmistry, 2012-12-03 22:03:06]

Adding a new skia_warnings_as_errors flag.

[EricB, 2012-12-04 13:30:05]

LGTM but would prefer if it worked across platforms.

[rmistry, 2012-12-04 13:35:33]

On 2012/12/04 13:30:05, EricB wrote:
> LGTM but would prefer if it worked across platforms.

I thought it would work across platforms, could you explain why it would not (I
am a gyp newbie).

[EricB, 2012-12-04 13:39:19]

On 2012/12/04 13:35:33, rmistry wrote:
> On 2012/12/04 13:30:05, EricB wrote:
> > LGTM but would prefer if it worked across platforms.
> 
> I thought it would work across platforms, could you explain why it would not
(I
> am a gyp newbie).

This only enables warnings-as-errors on Linux, since that conditional block is
Linux-specific.  I think it would be nice if the flag had the same effect on all
platforms.

[rmistry, 2012-12-04 13:44:35]

On 2012/12/04 13:39:19, EricB wrote:
> On 2012/12/04 13:35:33, rmistry wrote:
> > On 2012/12/04 13:30:05, EricB wrote:
> > > LGTM but would prefer if it worked across platforms.
> > 
> > I thought it would work across platforms, could you explain why it would not
> (I
> > am a gyp newbie).
> 
> This only enables warnings-as-errors on Linux, since that conditional block is
> Linux-specific.  I think it would be nice if the flag had the same effect on
all
> platforms.

I see it now. Giving it a shot..

[rmistry, 2012-12-04 14:46:15]

On 2012/12/04 13:44:35, rmistry wrote:
> On 2012/12/04 13:39:19, EricB wrote:
> > On 2012/12/04 13:35:33, rmistry wrote:
> > > On 2012/12/04 13:30:05, EricB wrote:
> > > > LGTM but would prefer if it worked across platforms.
> > > 
> > > I thought it would work across platforms, could you explain why it would
not
> > (I
> > > am a gyp newbie).
> > 
> > This only enables warnings-as-errors on Linux, since that conditional block
is
> > Linux-specific.  I think it would be nice if the flag had the same effect on
> all
> > platforms.
> 
> I see it now. Giving it a shot..

Done. PTAL.

[EricB, 2012-12-04 14:48:04]

https://codereview.appspot.com/6868055/diff/3004/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.appspot.com/6868055/diff/3004/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:23: '-Werror',
This works for Windows and Mac?

[rmistry, 2012-12-05 14:15:16]

https://codereview.appspot.com/6868055/diff/3004/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.appspot.com/6868055/diff/3004/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:23: '-Werror',
On 2012/12/04 14:48:04, EricB wrote:
> This works for Windows and Mac?

As discussed in person yesterday, this will probably not work so only turning it
on for linux and android. Also, added a comment in common_variables.gyp

[EricB, 2012-12-05 14:19:22]

On 2012/12/05 14:15:16, rmistry wrote:
> https://codereview.appspot.com/6868055/diff/3004/gyp/common_conditions.gypi
> File gyp/common_conditions.gypi (right):
> 
>
https://codereview.appspot.com/6868055/diff/3004/gyp/common_conditions.gypi#n...
> gyp/common_conditions.gypi:23: '-Werror',
> On 2012/12/04 14:48:04, EricB wrote:
> > This works for Windows and Mac?
> 
> As discussed in person yesterday, this will probably not work so only turning
it
> on for linux and android. Also, added a comment in common_variables.gyp

LGTM