Issue 6868054: Fix unicode leakage into httplib.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6868054: Fix unicode leakage into httplib. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by jcgregorio_google

Modified:
11 years, 9 months ago

Reviewers:
Ali Afshar

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Description

Fixes issues with binary request bodies which may result in: UnicodeDecodeError: 'ascii' codec can't decode byte 0x89 in position 235: ordinal not in range(128)

Patch Set 1 #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+103 lines, -13 lines)			Patch
M	apiclient/http.py	View	4 chunks	+21 lines, -9 lines	0 comments	Download
M	oauth2client/client.py	View	4 chunks	+29 lines, -2 lines	0 comments	Download
M	tests/test_http.py	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	tests/test_oauth2client.py	View	4 chunks	+33 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Ali Afshar

11 years, 9 months ago (2012-12-10 21:04:22 UTC) #2

On 2012/12/06 20:24:48, jcgregorio_google wrote:
> Submitting TBR.

LGTM

Expand All Messages | Collapse All Messages