Issue 6867085: Fix IBus.py errors.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6867085: Fix IBus.py errors. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by fujiwara

Modified:
13 years, 1 month ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix IBus.py errors. BUG=http://code.google.com/p/ibus/issues/detail?id=1559 TEST=ibus-anthy

Patch Set 1 #

Total comments: 2

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	bindings/pygobject/gi/overrides/IBus.py	View		2 chunks	+5 lines, -5 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

lgtm https://codereview.appspot.com/6867085/diff/1/bindings/pygobject/gi/overrides/IBus.py File bindings/pygobject/gi/overrides/IBus.py (right): https://codereview.appspot.com/6867085/diff/1/bindings/pygobject/gi/overrides/IBus.py#newcode201 bindings/pygobject/gi/overrides/IBus.py:201: prop_type = kwargs.pop('prop_type', type) What's the different of ...

13 years, 1 month ago (2012-12-10 13:59:17 UTC) #2

Peng

On 2012/12/10 13:59:17, Peng wrote: > lgtm > > https://codereview.appspot.com/6867085/diff/1/bindings/pygobject/gi/overrides/IBus.py > File bindings/pygobject/gi/overrides/IBus.py (right): > ...

13 years, 1 month ago (2012-12-10 13:59:59 UTC) #3

fujiwara

13 years, 1 month ago (2012-12-10 14:15:51 UTC) #4

https://codereview.appspot.com/6867085/diff/1/bindings/pygobject/gi/overrides...
File bindings/pygobject/gi/overrides/IBus.py (right):

https://codereview.appspot.com/6867085/diff/1/bindings/pygobject/gi/overrides...
bindings/pygobject/gi/overrides/IBus.py:201: prop_type = kwargs.pop('prop_type',
type)
On 2012/12/10 13:59:17, Peng wrote:
> What's the different of get & pop?

pop returns the value and deletes it in dict.

Expand All Messages | Collapse All Messages