Replace SkConsistentChecksum with SkCityHash (now including CityHash via DEPS)

Replace SkConsistentChecksum with SkCityHash (now including CityHash via DEPS)

Alternative to https://codereview.appspot.com/6847087/ ('Change SkConsistentChecksum to use SuperFastHash')
Committed: https://code.google.com/p/skia/source/detail?r=6701

[epoger, 2012-12-04 20:55:03]

Ben: please indicate whether I am hooking in the third_party code correctly.

Mike: please review as a whole.  Given Daniel Berlin's instruction in
https://codereview.appspot.com/6847087/ , I am 100% confident that this is OK
license-wise.  (But feel free to ask him if you like)

https://codereview.appspot.com/6867060/diff/1/DEPS
File DEPS (right):

https://codereview.appspot.com/6867060/diff/1/DEPS#newcode12
DEPS:12: "third_party/externals/cityhash" :
"http://cityhash.googlecode.com/svn/trunk@11",
not shown in the diff: I have also updated the svn:externals property on the
third_party/externals directory

[bungeman, 2012-12-04 21:23:09]

The third_party magic lgtm. This license is also much easier to understand :-)

https://codereview.appspot.com/6867060/diff/1/DEPS
File DEPS (right):

https://codereview.appspot.com/6867060/diff/1/DEPS#newcode12
DEPS:12: "third_party/externals/cityhash" :
"http://cityhash.googlecode.com/svn/trunk@11",
On 2012/12/04 20:55:03, epoger wrote:
> not shown in the diff: I have also updated the svn:externals property on the
> third_party/externals directory

This lgtm. I wish we didn't have this extra 'externals' directory in the way
though. I understand that it separates 'third_party' (checked in to the Skia
repository) from 'externals' (bring in from other repositories), but it seems
like a lot of extra depth for what it does.

[epoger, 2012-12-05 16:39:57]

On 2012/12/04 21:23:09, bungeman wrote:
> This lgtm. I wish we didn't have this extra 'externals' directory in the way
> though. I understand that it separates 'third_party' (checked in to the Skia
> repository) from 'externals' (bring in from other repositories), but it seems
> like a lot of extra depth for what it does.

Yeah.  The reason for its being is as you describe... I'm certainly open to
other solutions, if you can think of one.

Mike, I await your "big picture" review...

[reed1, 2012-12-05 16:52:43]

where is city.h and any other files? are they already checked in?

[epoger, 2012-12-05 16:56:49]

On 2012/12/05 16:52:43, reed1 wrote:
> where is city.h and any other files? are they already checked in?

They are brought in (from http://cityhash.googlecode.com/svn/trunk/src/ ) by the
magic of DEPS.

[reed1, 2012-12-05 17:03:35]

lgtm