Issue 6865053: Fixed remaining clang compiler warnings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6865053: Fixed remaining clang compiler warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by robertphillips

Modified:
12 years ago

Reviewers:
bsalomon, brian2

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

This will let us turn on warnings-as-errors on the clang housekeeper.

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -21 lines)			Patch
M	bench/BitmapRectBench.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gm/bitmaprect.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	gm/fatpathfill.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	gm/modecolorfilters.cpp	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	gm/tilemodes.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	include/utils/SkRunnable.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/SkMatrix44.cpp	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	tests/MatrixTest.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/RoundRectTest.cpp	View	5 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 4

brian2

On 2012/12/03 17:25:53, brian2 wrote: > On 2012/12/03 16:48:13, robertphillips wrote: > > Lgtn Lgtm ...

12 years ago (2012-12-03 17:26:13 UTC) #3

Message was sent while issue was closed.

committed as r6646