Issue 6858101: Rename SkTDLinkedList to SkTInternalLinked list, add some methods useful for forthcoming SkTLList.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6858101: Rename SkTDLinkedList to SkTInternalLinked list, add some methods useful for forthcoming SkTLList. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by bsalomon

Modified:
11 years, 6 months ago

Reviewers:
robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Rename SkTDLinkedList to SkTInternalLinked list, add some methods useful for forthcoming SkTLList.

Patch Set 2 : #

Total comments: 4

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -232 lines)			Patch
M	gyp/core.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download
D	include/core/SkTDLinkedList.h	View		1 chunk	+0 lines, -179 lines	0 comments	Download
A +	include/core/SkTInternalLList.h	View	1	5 chunks	+52 lines, -31 lines	0 comments	Download
M	include/gpu/GrResource.h	View		2 chunks	+2 lines, -2 lines	2 comments	Download
M	include/utils/SkThreadPool.h	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/gpu/GrGpu.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrResourceCache.h	View		4 chunks	+5 lines, -5 lines	2 comments	Download
M	tests/TDLinkedListTest.cpp	View		4 chunks	+8 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

Adding Rob... Rob, Mike and I thought that the the name was confusing since we ...

11 years, 6 months ago (2012-12-03 14:05:34 UTC) #2

robertphillips

LGTM + 2 ignoreable comment suggestions https://codereview.appspot.com/6858101/diff/2001/include/gpu/GrResource.h File include/gpu/GrResource.h (right): https://codereview.appspot.com/6858101/diff/2001/include/gpu/GrResource.h#newcode95 include/gpu/GrResource.h:95: Maybe change this ...

11 years, 6 months ago (2012-12-03 14:50:46 UTC) #3

bsalomon

11 years, 6 months ago (2012-12-03 14:54:55 UTC) #4

https://codereview.appspot.com/6858101/diff/2001/include/gpu/GrResource.h
File include/gpu/GrResource.h (right):

https://codereview.appspot.com/6858101/diff/2001/include/gpu/GrResource.h#new...
include/gpu/GrResource.h:95: 
On 2012/12/03 14:50:46, robertphillips wrote:
> Maybe change this comment to "We're in an internal doubly linked list"?

Done.

https://codereview.appspot.com/6858101/diff/2001/src/gpu/GrResourceCache.h
File src/gpu/GrResourceCache.h (right):

https://codereview.appspot.com/6858101/diff/2001/src/gpu/GrResourceCache.h#ne...
src/gpu/GrResourceCache.h:161: 
On 2012/12/03 14:50:46, robertphillips wrote:
> // We're an internal double linked list

Done.

Expand All Messages | Collapse All Messages