Issue 6858096: Make SkClipStack::Element public.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6858096: Make SkClipStack::Element public. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make SkClipStack::Element public. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6617

Patch Set 3 : Make SkClipStack::Element public. #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+460 lines, -406 lines)			Patch
	M	include/core/SkClipStack.h	View	1 2	4 chunks	+163 lines, -16 lines	0 comments	Download
	M	src/core/SkClipStack.cpp	View	1 2	1 chunk	+297 lines, -390 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robertphillips

LGTM + comment suggestions https://codereview.appspot.com/6858096/diff/2001/include/core/SkClipStack.h File include/core/SkClipStack.h (right): https://codereview.appspot.com/6858096/diff/2001/include/core/SkClipStack.h#newcode88 include/core/SkClipStack.h:88: SkRect fRect; comment here on ...

12 years, 1 month ago (2012-11-29 19:55:55 UTC) #2

bsalomon

Make SkClipStack::Element public. R=robertphillips@google.com

12 years, 1 month ago (2012-11-29 21:04:44 UTC) #3

bsalomon

12 years, 1 month ago (2012-11-29 21:05:17 UTC) #4

Message was sent while issue was closed.

https://codereview.appspot.com/6858096/diff/2001/include/core/SkClipStack.h
File include/core/SkClipStack.h (right):

https://codereview.appspot.com/6858096/diff/2001/include/core/SkClipStack.h#n...
include/core/SkClipStack.h:88: SkRect          fRect;
On 2012/11/29 19:55:55, robertphillips wrote:
> comment here on fSaveCount?

Done.

https://codereview.appspot.com/6858096/diff/2001/include/core/SkClipStack.h#n...
include/core/SkClipStack.h:105: SkRect                  fFiniteBound;
On 2012/11/29 19:55:55, robertphillips wrote:
> comment here on IIOR?

Done.

https://codereview.appspot.com/6858096/diff/2001/include/core/SkClipStack.h#n...
include/core/SkClipStack.h:126: fDoAA = doAA;
On 2012/11/29 19:55:55, robertphillips wrote:
> comment here on the IO_BT & empty convention?

Done.

Expand All Messages | Collapse All Messages