Enable profiling options to be selectively enabled for a given build

Enable profiling options to be selectively enabled for a given build

Committed: https://code.google.com/p/skia/source/detail?r=6598

[DerekS, 2012-11-28 17:12:53]

I need to be able to add additional compile flags when profiling, but if there
are better ways of doing it I'm open to changing this.

[EricB, 2012-11-28 17:47:47]

https://codereview.appspot.com/6858089/diff/2001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.appspot.com/6858089/diff/2001/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:293: [ 'skia_profile_enabled == 1', {
I don't think you need the "== 1" since Python considers 1 to be truth-y and 0
to be false-y.

https://codereview.appspot.com/6858089/diff/2001/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.appspot.com/6858089/diff/2001/gyp/common_variables.gypi#ne...
gyp/common_variables.gypi:89: 'skia_profile_enabled%': 0,
Does this flag only affect Android?  If so, maybe the flag should be named to
make that clear.

[DerekS, 2012-11-28 17:55:33]

https://codereview.appspot.com/6858089/diff/2001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.appspot.com/6858089/diff/2001/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:293: [ 'skia_profile_enabled == 1', {
On 2012/11/28 17:47:47, EricB wrote:
> I don't think you need the "== 1" since Python considers 1 to be truth-y and 0
> to be false-y.

I was just sticking with the style of the rest of this file.

https://codereview.appspot.com/6858089/diff/2001/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.appspot.com/6858089/diff/2001/gyp/common_variables.gypi#ne...
gyp/common_variables.gypi:89: 'skia_profile_enabled%': 0,
On 2012/11/28 17:47:47, EricB wrote:
> Does this flag only affect Android?  If so, maybe the flag should be named to
> make that clear.

For right now it only is used by android, but I suspect that other platforms
want to do something similar.  Basically, it allows me to build in release mode
while still including symbols and frame pointers.

[EricB, 2012-11-28 17:58:08]

LGTM

https://codereview.appspot.com/6858089/diff/2001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.appspot.com/6858089/diff/2001/gyp/common_conditions.gypi#n...
gyp/common_conditions.gypi:293: [ 'skia_profile_enabled == 1', {
On 2012/11/28 17:55:34, DerekS wrote:
> On 2012/11/28 17:47:47, EricB wrote:
> > I don't think you need the "== 1" since Python considers 1 to be truth-y and
0
> > to be false-y.
> 
> I was just sticking with the style of the rest of this file.

Makes sense.  We're pretty inconsistent about it.

https://codereview.appspot.com/6858089/diff/2001/gyp/common_variables.gypi
File gyp/common_variables.gypi (right):

https://codereview.appspot.com/6858089/diff/2001/gyp/common_variables.gypi#ne...
gyp/common_variables.gypi:89: 'skia_profile_enabled%': 0,
On 2012/11/28 17:55:34, DerekS wrote:
> On 2012/11/28 17:47:47, EricB wrote:
> > Does this flag only affect Android?  If so, maybe the flag should be named
to
> > make that clear.
> 
> For right now it only is used by android, but I suspect that other platforms
> want to do something similar.  Basically, it allows me to build in release
mode
> while still including symbols and frame pointers.

SGTM