Issue 6858073: remove legacy build-guards, now that webkit has rebaselined these.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6858073: remove legacy build-guards, now that webkit has rebaselined these. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by reed1

Modified:
11 years, 10 months ago

Reviewers:
bungeman, schenney, bsalomon, robertphillips, senorblanco

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

remove legacy build-guards, now that webkit has rebaselined these. SK_DISABLE_FAST_AA_STROKE_RECT SK_IGNORE_FAST_BLURRECT SK_DISABLE_EXTRACTSUBSET_OPAQUE_FIX SK_IGNORE_CF_OPTIMIZATION SK_IGNORE_NEW_STROKERECT SK_DISABLE_GPU_BLUR SK_IGNORE_ROTATED_FREETYPE_FIX The changes should all be: remove code for #ifdef remove guard for #ifndef Committed: https://code.google.com/p/skia/source/detail?r=6546

Patch Set 1 #

Patch Set 2 : #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -42 lines)			Patch
M	src/core/SkBlitter.cpp	View	2 chunks	+0 lines, -6 lines	0 comments	Download
M	src/core/SkBlitter_ARGB32.cpp	View	6 chunks	+1 line, -6 lines	0 comments	Download
M	src/core/SkCoreBlitters.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/core/SkDraw.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/core/SkMaskFilter.cpp	View	2 chunks	+1 line, -8 lines	0 comments	Download
M	src/core/SkPictureRecord.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/core/SkStroke.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/ports/SkFontHost_FreeType.cpp	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

reed1

11 years, 10 months ago (2012-11-26 16:19:33 UTC) #5

turns out chrome/src/skia/config/SkUserConfig.h does define
SK_DISABLE_DITHER_32BIT_GRADIENT, so I can't remove that yet.

Expand All Messages | Collapse All Messages