Issue 6856118: rebaseline.py: Allow multiple testnames on the command line.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6856118: rebaseline.py: Allow multiple testnames on the command line. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by Stephen White

Modified:
11 years, 7 months ago

Reviewers:
EricB

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn

Visibility:
Public.

More Reviews

Description

rebaseline.py: Allow multiple testnames on the command line. Committed: https://code.google.com/p/skia/source/detail?r=6623

Patch Set 2 : Update comment to reflect functionality. #

Patch Set 3 : Fix line length #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -33 lines)			Patch
	M	trunk/tools/rebaseline.py	View	1 2	2 chunks	+34 lines, -33 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

EricB

LGTM with nit. Thanks for working on this! https://codereview.appspot.com/6856118/diff/1/trunk/tools/rebaseline.py File trunk/tools/rebaseline.py (right): https://codereview.appspot.com/6856118/diff/1/trunk/tools/rebaseline.py#newcode41 trunk/tools/rebaseline.py:41: print ...

11 years, 7 months ago (2012-11-29 21:07:56 UTC) #2

Stephen White

11 years, 7 months ago (2012-11-29 21:27:18 UTC) #3

On 2012/11/29 21:07:56, EricB wrote:
> LGTM with nit.  Thanks for working on this!
> 
> https://codereview.appspot.com/6856118/diff/1/trunk/tools/rebaseline.py
> File trunk/tools/rebaseline.py (right):
> 
>
https://codereview.appspot.com/6856118/diff/1/trunk/tools/rebaseline.py#newco...
> trunk/tools/rebaseline.py:41: print 'Usage:  ' + os.path.basename(sys.argv[0])
+
> ' <testname> [ <testname> ... ]'
> Nit: > 80 chars

Done.

Expand All Messages | Collapse All Messages