Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(130)

Issue 6856107: code review 6856107: exp/types: various missing checks for array/slice compo... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by gri
Modified:
10 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

exp/types: various missing checks for array/slice composite literals - check indices of array/slice composite literals - handle [...]T - also: go/defer statements

Patch Set 1 #

Patch Set 2 : diff -r 9049dd504139 https://code.google.com/p/go #

Patch Set 3 : diff -r 9049dd504139 https://code.google.com/p/go #

Patch Set 4 : diff -r 1289e67dec66 https://code.google.com/p/go #

Patch Set 5 : diff -r 1289e67dec66 https://code.google.com/p/go #

Patch Set 6 : diff -r 1289e67dec66 https://code.google.com/p/go #

Patch Set 7 : diff -r 5ff1a3660917 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -115 lines) Patch
M src/pkg/exp/types/expr.go View 1 2 3 8 chunks +107 lines, -71 lines 0 comments Download
M src/pkg/exp/types/stmt.go View 1 2 3 4 2 chunks +17 lines, -2 lines 0 comments Download
M src/pkg/exp/types/testdata/decls0.src View 1 2 3 1 chunk +9 lines, -0 lines 0 comments Download
M src/pkg/exp/types/testdata/expr3.src View 1 2 3 4 chunks +96 lines, -41 lines 0 comments Download
M src/pkg/exp/types/testdata/stmt0.src View 1 2 3 4 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 4
gri
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years ago (2012-11-28 00:56:08 UTC) #1
gri
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years ago (2012-11-28 05:56:02 UTC) #2
rsc
LGTM
10 years ago (2012-11-29 17:33:29 UTC) #3
gri
10 years ago (2012-11-29 17:57:43 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=b44754d79b3f ***

exp/types: various missing checks for array/slice composite literals

- check indices of array/slice composite literals
- handle [...]T
- also: go/defer statements

R=rsc
CC=golang-dev
http://codereview.appspot.com/6856107
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b