various: use TLS

environs/ec2/live_test.go

 package ec2_test
 
 import (
         "crypto/rand"
         "fmt"
         "io"
         "io/ioutil"
         amzec2 "launchpad.net/goamz/ec2"
         . "launchpad.net/gocheck"
         "launchpad.net/juju-core/environs"
@@ skipping 170 matching lines @@
         }
 
         // The old juju group should have been reused.
         c.Check(groups[0].Id, Equals, oldJujuGroup.Id)
 
         // Check that it authorizes the correct ports and there
         // are no extra permissions (in particular we are checking
         // that the unneeded permission that we added earlier
         // has been deleted).
         perms := info[0].IPPerms
-        c.Assert(perms, HasLen, 4)
+        c.Assert(perms, HasLen, 5)
         checkPortAllowed(c, perms, 22)
+        checkPortAllowed(c, perms, ec2.MgoPort)

[niemeyer, 2012/11/28 15:58:37]

37017 should be tested explicitly, otherwise we're testing N against N, without
any idea of what N really is. A mistaken change goes through unnoticed.

[rog, 2012/11/28 18:08:05]

Done.

[niemeyer, 2012/11/28 18:37:51]

Apparently not.

         checkSecurityGroupAllowed(c, perms, groups[0])
 
         // The old machine group should have been reused also.
         c.Check(groups[2].Id, Equals, oldMachineGroup.Id)
 
         // Check that each instance is part of the correct groups.
         resp, err := ec2conn.Instances([]string{inst0.Id(), inst1.Id()}, nil)
         c.Assert(err, IsNil)
         c.Assert(resp.Reservations, HasLen, 2)
         for _, r := range resp.Reservations {
@@ skipping 186 matching lines @@
 }
 
 func hasSecurityGroup(r amzec2.Reservation, g amzec2.SecurityGroup) bool {
         for _, rg := range r.SecurityGroups {
                 if rg.Id == g.Id {
                         return true
                 }
         }
         return false
 }