Issue 6856063: Fix clang warning in GMSampleView.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6856063: Fix clang warning in GMSampleView.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by tfarina1

Modified:
11 years, 7 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Fix clang warning in GMSampleView.h ../../samplecode/GMSampleView.h:23:7: warning: field 'fGM' will be initialized after field 'fShowSize' [-Wreorder] R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=6507

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	samplecode/GMSampleView.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

11 years, 7 months ago (2012-11-19 20:38:35 UTC) #2

LGTM


On Mon, Nov 19, 2012 at 3:07 PM, <tfarina@chromium.org> wrote:

> Reviewers: bsalomon,
>
> Description:
> Fix clang warning in GMSampleView.h
>
> ../../samplecode/GMSampleView.**h:23:7: warning: field 'fGM' will be
> initialized after field 'fShowSize' [-Wreorder]
>
> R=bsalomon@google.com
>
>
> Please review this at
https://codereview.appspot.**com/6856063/<https://codereview.appspot.com/6856...
>
> Affected files:
>   M samplecode/GMSampleView.h
>
>
> Index: samplecode/GMSampleView.h
> diff --git a/samplecode/GMSampleView.h b/samplecode/GMSampleView.h
> index 93bafca85c9a9360ce0b68433d061a**e1cf30f504..**
> 6791c344c717923f3c48ea6d08e0fa**5ec6632fb6 100644
> --- a/samplecode/GMSampleView.h
> +++ b/samplecode/GMSampleView.h
> @@ -20,7 +20,7 @@ private:
>
>  public:
>      GMSampleView(GM* gm)
> -    : fGM(gm), fShowSize(false) {}
> +    : fShowSize(false), fGM(gm) {}
>
>      virtual ~GMSampleView() {
>          delete fGM;
>
>
>

Expand All Messages | Collapse All Messages