Templatize AutoCFRelease and use it.

Templatize AutoCFRelease and use it.

[bungeman, 2012-11-30 20:40:18]

This makes AutoCFRelease more generally useful and uses it.

[caryclark1, 2012-12-03 13:01:11]

https://codereview.appspot.com/6855113/diff/1/src/ports/SkFontHost_mac_corete...
File src/ports/SkFontHost_mac_coretext.cpp (right):

https://codereview.appspot.com/6855113/diff/1/src/ports/SkFontHost_mac_corete...
src/ports/SkFontHost_mac_coretext.cpp:62: bool operator !() const { return NULL
== fCFRef; }
This is worrisome and looks prone to abuse, because accidental casts to bool are
so easy to do. I would prefer to see:
   operator !=
   operator ==
and
   if (NULL != foo) 
etc. instead. This is the pattern that gpu code uses.

[bungeman, 2012-12-03 18:14:39]

Removed bool conversion operators.

https://codereview.appspot.com/6855113/diff/1/src/ports/SkFontHost_mac_corete...
File src/ports/SkFontHost_mac_coretext.cpp (right):

https://codereview.appspot.com/6855113/diff/1/src/ports/SkFontHost_mac_corete...
src/ports/SkFontHost_mac_coretext.cpp:62: bool operator !() const { return NULL
== fCFRef; }
On 2012/12/03 13:01:11, caryclark1 wrote:
> This is worrisome and looks prone to abuse, because accidental casts to bool
are
> so easy to do. I would prefer to see:
>    operator !=
>    operator ==
> and
>    if (NULL != foo) 
> etc. instead. This is the pattern that gpu code uses.
> 

Yes. It appears that Chromium's ScopedCFTypeRef agrees as well. Done.

[caryclark1, 2012-12-03 18:32:04]

lgtm

[bungeman, 2012-12-04 20:29:19]

Committed revision 6650.