Add a function that computes a reduced representation of the clip stack.

Add a function that computes a reduced representation of the clip stack.

Also adds a unit test. The function is not yet used other than in the test.
Committed: https://code.google.com/p/skia/source/detail?r=6553

[bsalomon, 2012-11-26 19:25:36]

https://codereview.appspot.com/6855098/diff/2001/tests/ClipStackTest.cpp
File tests/ClipStackTest.cpp (right):

https://codereview.appspot.com/6855098/diff/2001/tests/ClipStackTest.cpp#newc...
tests/ClipStackTest.cpp:688: // Is this correct? Ask Rob.
?

[robertphillips, 2012-11-26 19:51:33]

LGTM with nits

https://codereview.appspot.com/6855098/diff/2001/include/core/SkClipStack.h
File include/core/SkClipStack.h (right):

https://codereview.appspot.com/6855098/diff/2001/include/core/SkClipStack.h#n...
include/core/SkClipStack.h:149: /**
Do you think we will ever add an inverse filled rect? I think we could change
this comment to just be "Is the clip shape inverse filled?"

https://codereview.appspot.com/6855098/diff/2001/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.appspot.com/6855098/diff/2001/src/gpu/GrClipMaskManager.cp...
src/gpu/GrClipMaskManager.cpp:40: void GrReduceClipStack(const SkClipStack&
stack,
Maybe 'clips' -> 'resultClips'?

https://codereview.appspot.com/6855098/diff/2001/tests/ClipStackTest.cpp
File tests/ClipStackTest.cpp (right):

https://codereview.appspot.com/6855098/diff/2001/tests/ClipStackTest.cpp#newc...
tests/ClipStackTest.cpp:688: // Is this correct? Ask Rob.
I think it is correct but I would add an assert that it never happens.

https://codereview.appspot.com/6855098/diff/2001/tests/ClipStackTest.cpp#newc...
tests/ClipStackTest.cpp:742: // Replace operations short-circuit the optimizer.
We want to make sure that we test this code
use -> us

https://codereview.appspot.com/6855098/diff/2001/tests/ClipStackTest.cpp#newc...
tests/ClipStackTest.cpp:771: SkSize size = SkSize::Make(
overlength lines?

[bsalomon, 2012-11-26 21:01:07]

https://codereview.appspot.com/6855098/diff/2001/include/core/SkClipStack.h
File include/core/SkClipStack.h (right):

https://codereview.appspot.com/6855098/diff/2001/include/core/SkClipStack.h#n...
include/core/SkClipStack.h:149: /**
On 2012/11/26 19:51:33, robertphillips wrote:
> Do you think we will ever add an inverse filled rect? I think we could change
> this comment to just be "Is the clip shape inverse filled?"

Done.

https://codereview.appspot.com/6855098/diff/2001/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (right):

https://codereview.appspot.com/6855098/diff/2001/src/gpu/GrClipMaskManager.cp...
src/gpu/GrClipMaskManager.cpp:40: void GrReduceClipStack(const SkClipStack&
stack,
On 2012/11/26 19:51:33, robertphillips wrote:
> Maybe 'clips' -> 'resultClips'?

Done.

https://codereview.appspot.com/6855098/diff/2001/tests/ClipStackTest.cpp
File tests/ClipStackTest.cpp (right):

https://codereview.appspot.com/6855098/diff/2001/tests/ClipStackTest.cpp#newc...
tests/ClipStackTest.cpp:688: // Is this correct? Ask Rob.
On 2012/11/26 19:51:33, robertphillips wrote:
> I think it is correct but I would add an assert that it never happens.
> 

Updated comment, will figure out why we get here.

https://codereview.appspot.com/6855098/diff/2001/tests/ClipStackTest.cpp#newc...
tests/ClipStackTest.cpp:742: // Replace operations short-circuit the optimizer.
We want to make sure that we test this code
On 2012/11/26 19:51:33, robertphillips wrote:
> use -> us

Done.

https://codereview.appspot.com/6855098/diff/2001/tests/ClipStackTest.cpp#newc...
tests/ClipStackTest.cpp:771: SkSize size = SkSize::Make(
On 2012/11/26 19:51:33, robertphillips wrote:
> overlength lines?

I tried wrapping; it's worse :(