Issue 6855062: Remove GrRandom API in favor of SkRandom.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6855062: Remove GrRandom API in favor of SkRandom. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by tfarina1

Modified:
11 years, 5 months ago

Reviewers:
bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Remove GrRandom API in favor of SkRandom. TEST=tests R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=6539

Patch Set 2 : nextF -> nextRangeF #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -68 lines)			Patch
M	gyp/gpu.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	include/core/SkRandom.h	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	src/gpu/GrRandom.h	View		1 chunk	+0 lines, -55 lines	0 comments	Download
M	src/gpu/GrRedBlackTree.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/GLProgramsTest.cpp	View		2 chunks	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bsalomon

LGTM w/ one nit. https://codereview.appspot.com/6855062/diff/1/include/core/SkRandom.h File include/core/SkRandom.h (right): https://codereview.appspot.com/6855062/diff/1/include/core/SkRandom.h#newcode54 include/core/SkRandom.h:54: float nextF(float min, float max) ...

11 years, 5 months ago (2012-11-19 13:45:36 UTC) #2

reed1

https://codereview.appspot.com/6855062/diff/1/include/core/SkRandom.h File include/core/SkRandom.h (right): https://codereview.appspot.com/6855062/diff/1/include/core/SkRandom.h#newcode54 include/core/SkRandom.h:54: float nextF(float min, float max) { On 2012/11/19 13:45:36, ...

11 years, 5 months ago (2012-11-19 14:17:38 UTC) #3

tfarina1

11 years, 5 months ago (2012-11-19 19:48:41 UTC) #4

On 2012/11/19 19:48:41, tfarina1 wrote:

LGTM

Expand All Messages | Collapse All Messages