Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(53)

Issue 6854058: code review 6854058: archive/zip: handle extra data headers with no body (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by dfc
Modified:
1 year, 5 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

archive/zip: handle extra data headers with no body

Fixes issue 4393.

Patch Set 1 #

Patch Set 2 : diff -r 591fc8a0131a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9544314de8e8 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 9544314de8e8 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r dbf92f38bae0 https://go.googlecode.com/hg/ #

Patch Set 6 : diff -r dbf92f38bae0 https://go.googlecode.com/hg/ #

Patch Set 7 : diff -r dbf92f38bae0 https://go.googlecode.com/hg/ #

Patch Set 8 : diff -r dbf92f38bae0 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -1 line) Patch
M src/pkg/archive/zip/reader.go View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/archive/zip/zip_test.go View 1 2 3 4 2 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
1 year, 5 months ago #1
dfc
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
1 year, 5 months ago #2
bradfitz
LGTM I'd write >= 4 when about to read at least 4 bytes, but > ...
1 year, 5 months ago #3
dfc
1 year, 5 months ago #4
*** Submitted as http://code.google.com/p/go/source/detail?r=a26a8ada8f6e ***

archive/zip: handle extra data headers with no body

Fixes issue 4393.

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6854058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5