golxc: added configuration reading

golxc_test.go

 package golxc_test
 
 import (
+        "io/ioutil"
         . "launchpad.net/gocheck"
         "launchpad.net/golxc"
         "os"
         "os/user"
         "testing"
 )
 
 func Test(t *testing.T) { TestingT(t) }
 
+type EnvironSuite struct{}
+
+var _ = Suite(&EnvironSuite{})
+
+var lxcfile = `# MIRROR to be used by ubuntu template at container creation:
+# Leaving it undefined is fine
+#MIRROR="http://archive.ubuntu.com/ubuntu"
+# or·
+#MIRROR="http://<host-ip-addr>:3142/archive.ubuntu.com/ubuntu"
+
+# LXC_AUTO - whether or not to start containers symlinked under
+# /etc/lxc/auto
+LXC_AUTO="true"
+
+# Leave USE_LXC_BRIDGE as "true" if you want to use lxcbr0 for your
+# containers.  Set to "false" if you'll use virbr0 or another existing
+# bridge, or mavlan to your host's NIC.
+USE_LXC_BRIDGE="true"
+
+# LXC_BRIDGE and LXC_ADDR are changed against original for
+# testing purposes.
+LXC_BRIDGE="lxcbr9"
+LXC_ADDR="10.0.9.1"
+LXC_NETMASK="255.255.255.0"
+LXC_NETWORK="10.0.9.0/24"
+LXC_DHCP_RANGE="10.0.9.2,10.0.9.254"
+LXC_DHCP_MAX="253"
+
+LXC_SHUTDOWN_TIMEOUT=120`
+
+func (s *EnvironSuite) TestReadDefaultEnviron(c *C) {
+        // Test reading the environment.
+        f, err := ioutil.TempFile("/tmp", "lxc-test")

[fwereade, 2013/01/30 16:37:39]

c.MkDir()

[TheMue, 2013/01/31 15:54:11]

Done.

+        c.Assert(err, IsNil)
+        defer func() {
+                c.Assert(os.Remove(f.Name()), IsNil)
+        }()
+        _, err = f.WriteString(lxcfile)
+        c.Assert(err, IsNil)
+        c.Assert(f.Close(), IsNil)
+
+        orig := golxc.SetLXCDefaultFile(f.Name())
+        defer golxc.SetLXCDefaultFile(orig)
+
+        env, err := golxc.ReadDefaultEnviron()
+        c.Assert(err, IsNil)
+        c.Assert(len(env), Equals, 9)

[fwereade, 2013/01/30 16:37:39]

A `DeepEquals, map[string]string{...}` here might make this a bit clearer.

[TheMue, 2013/01/31 15:54:11]

Done.

+        c.Assert(env["MIRROR"], Equals, "")
+        c.Assert(env["LXC_AUTO"], Equals, "true")
+        c.Assert(env["USE_LXC_BRIDGE"], Equals, "true")
+        c.Assert(env["LXC_BRIDGE"], Equals, "lxcbr9")
+        c.Assert(env["LXC_ADDR"], Equals, "10.0.9.1")
+        c.Assert(env["LXC_NETMASK"], Equals, "255.255.255.0")
+        c.Assert(env["LXC_NETWORK"], Equals, "10.0.9.0/24")
+        c.Assert(env["LXC_DHCP_RANGE"], Equals, "10.0.9.2,10.0.9.254")
+        c.Assert(env["LXC_DHCP_MAX"], Equals, "253")
+        c.Assert(env["LXC_SHUTDOWN_TIMEOUT"], Equals, "120")
+}
+
+func (s *EnvironSuite) TestReadNotExistingDefaultEnviron(c *C) {
+        // Test reading a not existing environment.
+        orig := golxc.SetLXCDefaultFile("/tmp/not-existing-exc-test")

[fwereade, 2013/01/30 16:37:39]

filepath.Join(c.MkDir(), "does-not-exist")

[TheMue, 2013/01/31 15:54:11]

File isn't created, can be any non-existing name.

[fwereade, 2013/02/07 09:43:11]

Please make sure we're consistent with the other branch in use of c.MkDir().

+        defer golxc.SetLXCDefaultFile(orig)
+
+        _, err := golxc.ReadDefaultEnviron()
+        c.Assert(err, ErrorMatches, "error executing .*: Can't open /tmp/not-existing-exc-test")
+}
+
 type LXCSuite struct{}
 
 var _ = Suite(&LXCSuite{})
 
 func (s *LXCSuite) SetUpSuite(c *C) {
         u, err := user.Current()
         c.Assert(err, IsNil)
         if u.Uid != "0" {
                 // Has to be run as root!
                 c.Skip("tests must run as root")
@@ skipping 215 matching lines @@
         c.Assert(lc.Create("ubuntu"), IsNil)
         defer func() {
                 c.Assert(lc.Destroy(), IsNil)
         }()
         c.Assert(lc.Start("", ""), IsNil)
         defer func() {
                 c.Assert(lc.Stop(), IsNil)
         }()
         c.Assert(lc.Unfreeze(), ErrorMatches, "container .* is not frozen")
 }