Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(213)

Issue 6853065: make svg-edit working with gae

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by ReimarBauer
Modified:
1 year, 5 months ago
Reviewers:
thomas.j.waldmann
Visibility:
Public.

Description

make svg-edit working with gae

Patch Set 1 #

Total comments: 3

Patch Set 2 : removed mistakes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M MoinMoin/items/content.py View 1 5 chunks +14 lines, -18 lines 0 comments Download

Messages

Total messages: 2
Thomas.J.Waldmann
this is broken http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py File MoinMoin/items/content.py (right): http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py#newcode413 MoinMoin/items/content.py:413: def put_member(self, tf, name, content, content_length, ...
1 year, 5 months ago #1
ReimarBauer
1 year, 5 months ago #2
On 2012/11/18 18:17:46, Thomas.J.Waldmann wrote:
> this is broken

I know that it is doing so only with svg-edit. I played a little bit with
StringIO and it seems to me we can't use append mode for tar files with it.




> 
> http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py
> File MoinMoin/items/content.py (right):
> 
>
http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py#newcod...
> MoinMoin/items/content.py:413: def put_member(self, tf, name, content,
> content_length, expected_members):
> this can only work, if we receive all components in a single post.
> 
>
http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py#newcod...
> MoinMoin/items/content.py:1161: cache_key(usage='TarContainer',
name=self.name))
> this looks insane
> 
>
http://codereview.appspot.com/6853065/diff/1/MoinMoin/items/content.py#newcod...
> MoinMoin/items/content.py:1162: tarbuffer = StringIO(temp_fname)
> this even more
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5