Consolidate handling of scopes.

[Ali Afshar, 2012-11-16 18:36:53]

https://codereview.appspot.com/6853060/diff/8/oauth2client/util.py
File oauth2client/util.py (right):

https://codereview.appspot.com/6853060/diff/8/oauth2client/util.py#newcode132
oauth2client/util.py:132: """Converts scope value to a string.
A tiny bit more explanation about how different value types are handled, e.g.
'a' vs 'a b' vs ['a', 'b']

https://codereview.appspot.com/6853060/diff/8/tests/test_oauth2client_appengi...
File tests/test_oauth2client_appengine.py (right):

https://codereview.appspot.com/6853060/diff/8/tests/test_oauth2client_appengi...
tests/test_oauth2client_appengine.py:178: scope = [
Can we also test a scope set that is a string?

https://codereview.appspot.com/6853060/diff/8/tests/test_oauth2client_util.py
File tests/test_oauth2client_util.py (right):

https://codereview.appspot.com/6853060/diff/8/tests/test_oauth2client_util.py...
tests/test_oauth2client_util.py:23: ('a b', 'a b'),
Please add a generator expression, e.g. (s for s in ['a', b'])

[jcgregorio_google, 2012-11-16 20:43:00]

https://codereview.appspot.com/6853060/diff/8/oauth2client/util.py
File oauth2client/util.py (right):

https://codereview.appspot.com/6853060/diff/8/oauth2client/util.py#newcode132
oauth2client/util.py:132: """Converts scope value to a string.
On 2012/11/16 18:36:53, Ali Afshar wrote:
> A tiny bit more explanation about how different value types are handled, e.g.
> 'a' vs 'a b' vs ['a', 'b']

Done.

https://codereview.appspot.com/6853060/diff/8/tests/test_oauth2client_appengi...
File tests/test_oauth2client_appengine.py (right):

https://codereview.appspot.com/6853060/diff/8/tests/test_oauth2client_appengi...
tests/test_oauth2client_appengine.py:178: scope = [
On 2012/11/16 18:36:53, Ali Afshar wrote:
> Can we also test a scope set that is a string?

Done.

https://codereview.appspot.com/6853060/diff/8/tests/test_oauth2client_util.py
File tests/test_oauth2client_util.py (right):

https://codereview.appspot.com/6853060/diff/8/tests/test_oauth2client_util.py...
tests/test_oauth2client_util.py:23: ('a b', 'a b'),
On 2012/11/16 18:36:53, Ali Afshar wrote:
> Please add a generator expression, e.g. (s for s in ['a', b'])

Done.

[Ali Afshar, 2012-11-16 20:57:55]

LGTM

[jcgregorio_google, 2012-11-16 21:37:11]

On 2012/11/16 20:57:55, Ali Afshar wrote:
> LGTM

Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=8a626c44224...