Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(770)

Issue 6853048: cmd/builddb: add support for quantal (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by dave
Modified:
11 years, 11 months ago
Reviewers:
niemeyer, TheMue, mp+134238, rog
Visibility:
Public.

Description

cmd/builddb: add support for quantal Add support for building a quantal spec mongodb https://code.launchpad.net/~dave-cheney/juju-core/046-cmd-builddb-quantal/+merge/134238 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/builddb: add support for quantal #

Patch Set 3 : cmd/builddb: add support for quantal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -1 line) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/builddb/main.go View 2 chunks +2 lines, -1 line 0 comments Download
A cmd/builddb/quantal/builddb/hooks/install View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
A cmd/builddb/quantal/builddb/hooks/start View 1 chunk +5 lines, -0 lines 0 comments Download
A cmd/builddb/quantal/builddb/metadata.yaml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6
dave_cheney.net
Please take a look.
12 years ago (2012-11-14 01:06:00 UTC) #1
dave_cheney.net
Please take a look.
12 years ago (2012-11-14 04:42:08 UTC) #2
rog
On 2012/11/14 04:42:08, dfc wrote: > Please take a look. LGTM seems a pity we ...
12 years ago (2012-11-14 09:18:09 UTC) #3
TheMue
LGTM
12 years ago (2012-11-14 09:19:16 UTC) #4
niemeyer
On 2012/11/14 09:18:09, rog wrote: > On 2012/11/14 04:42:08, dfc wrote: > > Please take ...
12 years ago (2012-11-14 17:01:03 UTC) #5
niemeyer
12 years ago (2012-11-14 17:01:44 UTC) #6
LGTM, but only if the duplication is avoided.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b