Issue 6852081: environs/config: old (reverted) CL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6852081: environs/config: old (reverted) CL

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by rog

Modified:
11 years, 5 months ago

Reviewers:
mp+135468

Visibility:
Public.

Description

environs/config: old (reverted) CL This is here for reference purposes, so we can view all the old changes. https://code.launchpad.net/~rogpeppe/juju-core/162-config-root-cert-reapply/+merge/135468 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/config: old (reverted) CL #

Patch Set 3 : environs/config: old (reverted) CL #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+618 lines, -172 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/bootstrap_test.go	View		3 chunks	+4 lines, -9 lines	0 comments	Download
M	cmd/juju/cmd_test.go	View		3 chunks	+10 lines, -1 line	0 comments	Download
M	cmd/juju/main_test.go	View		3 chunks	+42 lines, -16 lines	0 comments	Download
M	cmd/jujud/bootstrap_test.go	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	environs/cloudinit/cloudinit_test.go	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	environs/config.go	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	environs/config/authkeys.go	View		3 chunks	+37 lines, -1 line	0 comments	Download
M	environs/config/config.go	View		6 chunks	+92 lines, -10 lines	0 comments	Download
M	environs/config/config_test.go	View		6 chunks	+286 lines, -86 lines	0 comments	Download
M	environs/config_test.go	View		7 chunks	+72 lines, -30 lines	0 comments	Download
M	environs/dummy/config_test.go	View		3 chunks	+9 lines, -3 lines	0 comments	Download
M	environs/dummy/environs_test.go	View		1 chunk	+7 lines, -5 lines	0 comments	Download
M	environs/ec2/config_test.go	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	environs/ec2/live_test.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/ec2/local_test.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/open_test.go	View		3 chunks	+5 lines, -0 lines	0 comments	Download
M	environs/tools_test.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/conn_test.go	View		7 chunks	+10 lines, -6 lines	0 comments	Download
M	juju/testing/conn.go	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	state/state_test.go	View		10 chunks	+14 lines, -0 lines	0 comments	Download
M	testing/cert.go	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	worker/uniter/uniter_test.go	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

niemeyer

Assuming this is just reverting the revert that took approved changes out, LGTM once the ...

11 years, 5 months ago (2012-11-22 16:06:48 UTC) #2

rog

11 years, 5 months ago (2012-11-23 16:09:07 UTC) #3

*** Submitted:

environs/config: old (reverted) CL

This is here for reference purposes, so we
can view all the old changes.

R=niemeyer
CC=
https://codereview.appspot.com/6852081

Expand All Messages | Collapse All Messages