Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(370)

Issue 6852080: state: use string IDs for machines

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 4 months ago by fwereade
Modified:
11 years, 3 months ago
Reviewers:
aram, niemeyer, mp+135423, TheMue
Visibility:
Public.

Description

state: use string IDs for machines ok, this is *huge*, but most changes are just s/int/string/ and those left over are (1) obvious and (2) for the better IMO. https://code.launchpad.net/~fwereade/juju-core/machine-string-ids/+merge/135423 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 15

Patch Set 2 : state: use string IDs for machines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+283 lines, -284 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
D cmd/juju/export_test.go View 1 chunk +0 lines, -5 lines 0 comments Download
M cmd/juju/ssh.go View 1 3 chunks +8 lines, -9 lines 0 comments Download
M cmd/juju/status.go View 6 chunks +6 lines, -24 lines 0 comments Download
M cmd/juju/status_test.go View 16 chunks +27 lines, -33 lines 0 comments Download
M cmd/jujud/bootstrap_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M cmd/jujud/machine.go View 2 chunks +3 lines, -3 lines 0 comments Download
M cmd/jujud/machine_test.go View 3 chunks +3 lines, -3 lines 0 comments Download
M environs/cloudinit/cloudinit.go View 1 3 chunks +5 lines, -5 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 1 4 chunks +5 lines, -5 lines 0 comments Download
M environs/dummy/environs.go View 1 7 chunks +11 lines, -11 lines 0 comments Download
M environs/ec2/ec2.go View 1 8 chunks +10 lines, -10 lines 0 comments Download
M environs/ec2/export_test.go View 1 chunk +1 line, -1 line 0 comments Download
M environs/ec2/live_test.go View 1 5 chunks +7 lines, -7 lines 0 comments Download
M environs/ec2/local_test.go View 1 1 chunk +1 line, -1 line 0 comments Download
M environs/interface.go View 1 2 chunks +4 lines, -4 lines 0 comments Download
M environs/jujutest/livetests.go View 1 6 chunks +32 lines, -32 lines 0 comments Download
M environs/jujutest/tests.go View 1 1 chunk +2 lines, -2 lines 0 comments Download
M environs/openstack/provider.go View 1 1 chunk +1 line, -1 line 0 comments Download
M juju/testing/conn.go View 1 1 chunk +1 line, -1 line 0 comments Download
M state/assign_test.go View 9 chunks +12 lines, -10 lines 0 comments Download
M state/conn_test.go View 1 2 chunks +0 lines, -13 lines 0 comments Download
M state/machine.go View 7 chunks +7 lines, -8 lines 0 comments Download
M state/machine_test.go View 1 chunk +1 line, -1 line 0 comments Download
M state/service.go View 1 chunk +1 line, -1 line 0 comments Download
M state/state.go View 1 7 chunks +29 lines, -9 lines 0 comments Download
M state/state_test.go View 1 15 chunks +54 lines, -36 lines 0 comments Download
M state/unit.go View 9 chunks +21 lines, -20 lines 0 comments Download
M state/watcher.go View 5 chunks +9 lines, -9 lines 0 comments Download
M worker/firewaller/firewaller.go View 9 chunks +10 lines, -10 lines 0 comments Download
M worker/firewaller/firewaller_test.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/machiner/machiner.go View 1 chunk +1 line, -1 line 0 comments Download
M worker/provisioner/provisioner.go View 4 chunks +6 lines, -6 lines 0 comments Download
M worker/provisioner/provisioner_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10
fwereade
Please take a look.
11 years, 4 months ago (2012-11-21 14:40:13 UTC) #1
TheMue
LGTM, only have comments that we typically quote string ids with %q. But later I've ...
11 years, 4 months ago (2012-11-21 15:53:54 UTC) #2
fwereade
On 2012/11/21 15:53:54, TheMue wrote: > LGTM, only have comments that we typically quote string ...
11 years, 4 months ago (2012-11-21 17:09:55 UTC) #3
niemeyer
Representing ints as strings honestly feels like a lesser design, and this specific branch doesn't ...
11 years, 4 months ago (2012-11-21 23:08:07 UTC) #4
fwereade
OK, I'm somewhat nervous about the "ok if you're willing to revert" sentiment. This is ...
11 years, 4 months ago (2012-11-22 08:41:21 UTC) #5
fwereade
On 2012/11/21 23:08:07, niemeyer wrote: > Representing ints as strings honestly feels like a lesser ...
11 years, 4 months ago (2012-11-22 08:45:31 UTC) #6
fwereade
On 2012/11/22 08:45:31, fwereade wrote: > On 2012/11/21 23:08:07, niemeyer wrote: > > Representing ints ...
11 years, 4 months ago (2012-11-22 09:31:48 UTC) #7
niemeyer
On Thu, Nov 22, 2012 at 6:45 AM, <fwereade@gmail.com> wrote: > I'm not sure that ...
11 years, 4 months ago (2012-11-22 13:38:14 UTC) #8
fwereade
*** Submitted: state: use string IDs for machines ok, this is *huge*, but most changes ...
11 years, 4 months ago (2012-11-28 15:35:31 UTC) #9
aram
11 years, 3 months ago (2012-12-03 16:27:34 UTC) #10
Finally we have this! Thank you William.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b