Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(649)

Issue 6851124: Fix test app to ensure that we destroy our GPU resources. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 12 months ago by DerekS
Modified:
11 years, 12 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Fix test app to ensure that we destroy our GPU resources. The problem arises on devices like the Nexus 10 where we allow the destruction of resources using the destructor of a static variable. However, we have no guarentee that the GPU driver has not already cleaned up it's resources prior to our static destructor. Committed: https://code.google.com/p/skia/source/detail?r=6599

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M tests/Test.h View 1 chunk +1 line, -0 lines 0 comments Download
M tests/Test.cpp View 1 chunk +13 lines, -4 lines 0 comments Download
M tests/skia_test.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
DerekS
11 years, 12 months ago (2012-11-29 15:22:51 UTC) #1
robertphillips
11 years, 12 months ago (2012-11-29 15:25:09 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b