Modify the blur bench to add tests for high-quality blurs, and large non-integer blurs. Change the…

Modify the blur bench to add tests for high-quality blurs, and large non-integer blurs.  Change the Coarse flag (which just turns on separable blurs) to an #ifdef, since separable is no longer just Coarse.  (This #ifdef will hopefully be shortlived, once Chrome has switched).

The separable blur algorithm gives +45% on SampleBlur, +84% on SampleBigBlur, +31% on TheVerge, +35 to +85% on blurbench in HQ (depending on size), +8 to +35% in low quality.  (All of these on 32bit MacPro).

Committed: https://code.google.com/p/skia/source/detail?r=6601

[Stephen White, 2012-11-28 20:48:30]

PTAL

[reed1, 2012-11-28 21:34:19]

This change looks good. Did you mean to add tests or benches to this CL?

[reed1, 2012-11-28 21:34:43]

n/m -- I just missed that file :)

[reed1, 2012-11-28 21:35:09]

lgtm

[reed1, 2012-11-29 14:40:13]

lgtm (with trivial style nits)

can you add quick perf summary/chart to the CL comment (unless that is pending
some other perf change later on).

https://codereview.appspot.com/6851117/diff/2003/src/effects/SkBlurMask.cpp
File src/effects/SkBlurMask.cpp (right):

https://codereview.appspot.com/6851117/diff/2003/src/effects/SkBlurMask.cpp#n...
src/effects/SkBlurMask.cpp:862: // Force high quality off for small radii
(performance)
nit: use { } for the 'if' statement.

https://codereview.appspot.com/6851117/diff/2003/src/effects/SkBlurMask.cpp#n...
src/effects/SkBlurMask.cpp:912: get_adjusted_radii(passRadius, &loRadius,
&hiRadius);
nit: if (kHigh_Quality == quality) {

reverse the compare to avoid accidental assignment.

[Stephen White, 2012-11-29 17:08:52]

On 2012/11/29 14:40:13, reed1 wrote:
> lgtm (with trivial style nits)
> 
> can you add quick perf summary/chart to the CL comment (unless that is pending
> some other perf change later on).

Done.

> https://codereview.appspot.com/6851117/diff/2003/src/effects/SkBlurMask.cpp
> File src/effects/SkBlurMask.cpp (right):
> 
>
https://codereview.appspot.com/6851117/diff/2003/src/effects/SkBlurMask.cpp#n...
> src/effects/SkBlurMask.cpp:862: // Force high quality off for small radii
> (performance)
> nit: use { } for the 'if' statement.

Will fix on landing.

https://codereview.appspot.com/6851117/diff/2003/src/effects/SkBlurMask.cpp#n...
> src/effects/SkBlurMask.cpp:912: get_adjusted_radii(passRadius, &loRadius,
> &hiRadius);
> nit: if (kHigh_Quality == quality) {
> 
> reverse the compare to avoid accidental assignment.

Will fix on landing (here and elsewhere in this file).