Issue 6851111: change SkDrawFilter::filter to return a bool, where false means don't-draw

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6851111: change SkDrawFilter::filter to return a bool, where false means don't-draw (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by reed1

Modified:
11 years, 7 months ago

Reviewers:
Leon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

change SkDrawFilter::filter to return a bool, where false means don't-draw Committed: https://code.google.com/p/skia/source/detail?r=6551

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -14 lines)			Patch
M	gm/gmmain.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	include/core/SkDrawFilter.h	View	1 chunk	+6 lines, -3 lines	1 comment	Download
M	include/effects/SkPaintFlagsDrawFilter.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	samplecode/SampleLayers.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/core/SkCanvas.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/effects/SkPaintFlagsDrawFilter.cpp	View	3 chunks	+2 lines, -3 lines	0 comments	Download
M	tools/PictureRenderer.cpp	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Leon

11 years, 7 months ago (2012-11-26 20:20:58 UTC) #2

lgtm

https://codereview.appspot.com/6851111/diff/1/include/core/SkDrawFilter.h
File include/core/SkDrawFilter.h (right):

https://codereview.appspot.com/6851111/diff/1/include/core/SkDrawFilter.h#new...
include/core/SkDrawFilter.h:39: kTypeCount = kText_Type + 1
Is this the new preferred way to count enums?

Expand All Messages | Collapse All Messages