Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(83)

Issue 6851063: Add SkMatrix44::setColMajord, etc. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by vollick
Modified:
11 years, 7 months ago
Reviewers:
reed, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add SkMatrix44::setColMajord, etc. We have accessors for efficiently getting the matirx data, and it would be nice if we had similar methods for setting the matrix entries. Committed: https://code.google.com/p/skia/source/detail?r=6494

Patch Set 1 #

Patch Set 2 : Added documentation for new methods. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -42 lines) Patch
M include/utils/SkMatrix44.h View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/utils/SkMatrix44.cpp View 1 chunk +46 lines, -0 lines 0 comments Download
M tests/Matrix44Test.cpp View 1 chunk +65 lines, -42 lines 0 comments Download

Messages

Total messages: 4
vollick
11 years, 7 months ago (2012-11-17 03:43:30 UTC) #1
reed1
lgtm Would be nice to add some dox in the header for these (and the ...
11 years, 7 months ago (2012-11-19 13:35:35 UTC) #2
vollick
On 2012/11/19 13:35:35, reed1 wrote: > lgtm > > Would be nice to add some ...
11 years, 7 months ago (2012-11-19 21:01:56 UTC) #3
reed1
11 years, 7 months ago (2012-11-19 21:04:24 UTC) #4
Thanks for the dox.

The next proper stage is to format those so they will line-up with each method
after we run doxygen. We don't do this in a regular way, but we should soon :)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b