Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2360)

Issue 6851053: Reorder the separable blur passes into XXX/YYY, with an image transpose on the (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by Stephen White
Modified:
11 years, 7 months ago
Reviewers:
TomH, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Reorder the separable blur passes into XXX/YYY, with an image transpose on the last pass of each group. This results in continuguous memory reads in all passes, giving a 22% speedup on theverge.skp over the previous separable implementation, and a 30%-50% improvement over the existing implementation (depending on platform). Committed: https://code.google.com/p/skia/source/detail?r=6445

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -63 lines) Patch
M src/effects/SkBlurMask.cpp View 2 chunks +31 lines, -63 lines 0 comments Download

Messages

Total messages: 4
Stephen White
PTAL. Thanks!
11 years, 7 months ago (2012-11-15 19:43:14 UTC) #1
reed1
The speedup sounds great. I suggest adding some block-comments, perhaps on these helper functions, would ...
11 years, 7 months ago (2012-11-15 20:14:17 UTC) #2
Stephen White
On 2012/11/15 20:14:17, reed1 wrote: > The speedup sounds great. I suggest adding some block-comments, ...
11 years, 7 months ago (2012-11-15 20:29:30 UTC) #3
TomH
11 years, 7 months ago (2012-11-15 22:50:42 UTC) #4
Sweet speedup!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b