Issue 6851048: Allow SkPicture-derived classes install their own SkPicturePlayback-derived object

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6851048: Allow SkPicture-derived classes install their own SkPicturePlayback-derived object (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by robertphillips

Modified:
11 years, 7 months ago

Reviewers:
DerekS, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This CL allows SkPicture-derived classes to override SkPicture's ctors to install their own SkPicturePlayback-derived objects. The skp version needs to be exposed to allow derived SkPicture classes to be able to check the stream's version number themselves. Note, I tried adding a virtual 'createPlaybackObj' entry point but, given SkPicture's handling of playback objects this seemed even more fragile then this approach.

Patch Set 1 #

Patch Set 2 : removed debugger.gyp #

Total comments: 2

Patch Set 3 : Fixed typo #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -15 lines)			Patch
	M	include/core/SkPicture.h	View	1 2	2 chunks	+15 lines, -4 lines	0 comments	Download
	M	src/core/SkPicture.cpp	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

DerekS

lgtm with one nit https://codereview.appspot.com/6851048/diff/2001/include/core/SkPicture.h File include/core/SkPicture.h (right): https://codereview.appspot.com/6851048/diff/2001/include/core/SkPicture.h#newcode164 include/core/SkPicture.h:164: // install their own SkPicturePlayback-derived ...

11 years, 7 months ago (2012-11-13 20:37:08 UTC) #2

robertphillips

11 years, 7 months ago (2012-11-13 20:41:47 UTC) #4

committed as r6405

https://codereview.appspot.com/6851048/diff/2001/include/core/SkPicture.h
File include/core/SkPicture.h (right):

https://codereview.appspot.com/6851048/diff/2001/include/core/SkPicture.h#new...
include/core/SkPicture.h:164: // install their own SkPicturePlayback-derived
playes,SkPictureRecord-derived
On 2012/11/13 20:37:08, DerekS wrote:
> s/playes/players

Done.

Expand All Messages | Collapse All Messages