Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74)

Issue 6850091: code review 6850091: go.crypto/bn256: ensure that t is initialised correctly. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by agl1
Modified:
7 years ago
Reviewers:
bradfitz
CC:
golang-dev
Visibility:
Public.

Description

go.crypto/bn256: ensure that t is initialised correctly. t caches the value of z squared, but wasn't getting correctly initialised when the value of z was reset.

Patch Set 1 #

Patch Set 2 : diff -r 7fd55a277056 https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 7fd55a277056 https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r cf51e694ba75 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M bn256/bn256.go View 1 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 4
agl1
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
7 years ago (2012-11-22 18:43:54 UTC) #1
agl1
*** Submitted as http://code.google.com/p/go/source/detail?r=b2b2ae1f5140&repo=crypto *** go.crypto/bn256: ensure that t is initialised correctly. t caches the ...
7 years ago (2012-11-22 18:45:20 UTC) #2
bradfitz
No test? On Thu, Nov 22, 2012 at 10:45 AM, <agl@golang.org> wrote: > *** Submitted ...
7 years ago (2012-11-22 18:57:10 UTC) #3
agl1
7 years ago (2012-11-22 21:13:34 UTC) #4
On Thu, Nov 22, 2012 at 1:57 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> No test?

It blows up in the middle of a few thousand lines of test in another
package sadly. I wanted to sync the fix to some other machines first
to confirm that it works and I'll see about reducing the test case
now.


Cheers

AGL
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b