Add drawing of paths to debugger

This CL adds a new pane to the debugger that displays the current path if the current command is either a clipPath or a drawPath.

[DerekS, 2012-11-21 13:33:46]

https://codereview.appspot.com/6850082/diff/1/debugger/QT/SkImageWidget.h
File debugger/QT/SkImageWidget.h (right):

https://codereview.appspot.com/6850082/diff/1/debugger/QT/SkImageWidget.h#new...
debugger/QT/SkImageWidget.h:5: *      Author: chudy
replace this with our standard header

https://codereview.appspot.com/6850082/diff/1/debugger/SkDebugCanvas.cpp
File debugger/SkDebugCanvas.cpp (right):

https://codereview.appspot.com/6850082/diff/1/debugger/SkDebugCanvas.cpp#newc...
debugger/SkDebugCanvas.cpp:179: SkAutoTUnref<SkCanvas> canvas(new
SkCanvas(device));
why not just put the canvas on the stack?

https://codereview.appspot.com/6850082/diff/1/debugger/SkDebugCanvas.cpp#newc...
debugger/SkDebugCanvas.cpp:203: SkBitmap* bitmap = createBitmap(path);
You can put the bitmap on the stack and pass it to createBitmap to avoid having
to manage it's lifetime on the heap.

This change would require the drawCommand to use the bitmap's copy constructor
(won't copy the pixels)

https://codereview.appspot.com/6850082/diff/1/debugger/SkDrawCommand.h
File debugger/SkDrawCommand.h (right):

https://codereview.appspot.com/6850082/diff/1/debugger/SkDrawCommand.h#newcode78
debugger/SkDrawCommand.h:78: const SkBitmap* fBitmap;
just make a copy of the bitmap and store it instead of having to delete the
pointer when the object goes away.

[robertphillips, 2012-11-21 16:06:20]

https://codereview.appspot.com/6850082/diff/1/debugger/QT/SkImageWidget.h
File debugger/QT/SkImageWidget.h (right):

https://codereview.appspot.com/6850082/diff/1/debugger/QT/SkImageWidget.h#new...
debugger/QT/SkImageWidget.h:5: *      Author: chudy
On 2012/11/21 13:33:47, DerekS wrote:
> replace this with our standard header

Done.

https://codereview.appspot.com/6850082/diff/1/debugger/SkDebugCanvas.cpp
File debugger/SkDebugCanvas.cpp (right):

https://codereview.appspot.com/6850082/diff/1/debugger/SkDebugCanvas.cpp#newc...
debugger/SkDebugCanvas.cpp:179: SkAutoTUnref<SkCanvas> canvas(new
SkCanvas(device));
On 2012/11/21 13:33:47, DerekS wrote:
> why not just put the canvas on the stack?

Done.

https://codereview.appspot.com/6850082/diff/1/debugger/SkDebugCanvas.cpp#newc...
debugger/SkDebugCanvas.cpp:203: SkBitmap* bitmap = createBitmap(path);
On 2012/11/21 13:33:47, DerekS wrote:
> You can put the bitmap on the stack and pass it to createBitmap to avoid
having
> to manage it's lifetime on the heap.
> 
> This change would require the drawCommand to use the bitmap's copy constructor
> (won't copy the pixels)

Done.

https://codereview.appspot.com/6850082/diff/1/debugger/SkDrawCommand.h
File debugger/SkDrawCommand.h (right):

https://codereview.appspot.com/6850082/diff/1/debugger/SkDrawCommand.h#newcode78
debugger/SkDrawCommand.h:78: const SkBitmap* fBitmap;
On 2012/11/21 13:33:47, DerekS wrote:
> just make a copy of the bitmap and store it instead of having to delete the
> pointer when the object goes away.

Done.

[DerekS, 2012-11-21 16:24:45]

lgtm with the following nits.

https://codereview.appspot.com/6850082/diff/11002/debugger/QT/SkImageWidget.cpp
File debugger/QT/SkImageWidget.cpp (right):

https://codereview.appspot.com/6850082/diff/11002/debugger/QT/SkImageWidget.c...
debugger/QT/SkImageWidget.cpp:48: painter.drawRect(0, 0, 256, 256);
should we draw based on the bitmap size (which we have already setup to be
256x256)?

https://codereview.appspot.com/6850082/diff/11002/debugger/SkDebugCanvas.cpp
File debugger/SkDebugCanvas.cpp (right):

https://codereview.appspot.com/6850082/diff/11002/debugger/SkDebugCanvas.cpp#...
debugger/SkDebugCanvas.cpp:177: SkDevice* device = new SkDevice(bitmap);
don't you need to unref this after assigning it to the canvas?

https://codereview.appspot.com/6850082/diff/11002/debugger/SkDebugCanvas.cpp#...
debugger/SkDebugCanvas.cpp:202: 
remove space

https://codereview.appspot.com/6850082/diff/11002/debugger/SkDebugCanvas.cpp#...
debugger/SkDebugCanvas.cpp:251: 
remove space

[robertphillips, 2012-11-21 17:11:35]

committed as r6532

https://codereview.appspot.com/6850082/diff/11002/debugger/QT/SkImageWidget.cpp
File debugger/QT/SkImageWidget.cpp (right):

https://codereview.appspot.com/6850082/diff/11002/debugger/QT/SkImageWidget.c...
debugger/QT/SkImageWidget.cpp:48: painter.drawRect(0, 0, 256, 256);
All the 256's devolve from the image widget's size. I have just changed them all
to use constants from the image widget class.

https://codereview.appspot.com/6850082/diff/11002/debugger/SkDebugCanvas.cpp
File debugger/SkDebugCanvas.cpp (right):

https://codereview.appspot.com/6850082/diff/11002/debugger/SkDebugCanvas.cpp#...
debugger/SkDebugCanvas.cpp:177: SkDevice* device = new SkDevice(bitmap);
On 2012/11/21 16:24:45, DerekS wrote:
> don't you need to unref this after assigning it to the canvas?

Done.

https://codereview.appspot.com/6850082/diff/11002/debugger/SkDebugCanvas.cpp#...
debugger/SkDebugCanvas.cpp:202: 
On 2012/11/21 16:24:45, DerekS wrote:
> remove space

Done.

https://codereview.appspot.com/6850082/diff/11002/debugger/SkDebugCanvas.cpp#...
debugger/SkDebugCanvas.cpp:251: 
On 2012/11/21 16:24:45, DerekS wrote:
> remove space

Done.