Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(118)

Issue 6850066: Fix a memory leak in skdiff that happens when the (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by Leon
Modified:
11 years, 10 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Fix a memory leak in skdiff that happens when the directories do not contain the same files. Only create the bitmaps when we need to use them. Committed: https://code.google.com/p/skia/source/detail?r=6481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -20 lines) Patch
M tools/skdiff_main.cpp View 4 chunks +35 lines, -20 lines 0 comments Download

Messages

Total messages: 2
Leon
11 years, 10 months ago (2012-11-16 21:57:23 UTC) #1
TomH
11 years, 10 months ago (2012-11-19 11:04:04 UTC) #2
LGTM.

Food for thought: If the bitmaps are only being used in that one subtree of the
code, and don't need to persist outside it, do they really need to belong to the
DRP?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b