providers/ec2: support VPC

providers/ec2: support VPC

To use VPC, all the user need to do is add two new environment settings: vpc_id
and subnet_id.

This CL depends on three other CLs (related to txaws):

 - https://codereview.appspot.com/6826065/
 - https://codereview.appspot.com/6822097/
 - https://codereview.appspot.com/6814123/

** NOT FOR MERGE **

https://code.launchpad.net/~franciscosouza/juju/juju-vpc/+merge/134169

(do not edit description out of merge proposal)

[fss, 2012-11-13 18:36:17]

Please take a look.

[fss, 2012-11-13 18:45:38]

Please take a look.

[fss, 2012-11-14 19:55:49]

Please take a look.

[fss, 2012-11-21 16:27:48]

Please take a look.

[fss, 2012-11-21 21:08:41]

Please take a look.

[fss, 2012-11-22 13:28:21]

Please take a look.

[hazmat, 2012-11-22 13:44:07]

one comment regarding correctness.

https://codereview.appspot.com/6850044/diff/7017/juju/providers/ec2/securityg...
File juju/providers/ec2/securitygroup.py (right):

https://codereview.appspot.com/6850044/diff/7017/juju/providers/ec2/securityg...
juju/providers/ec2/securitygroup.py:11: for group in d.result:
This is very suspect, deferred results should not be access directly, this needs
a callback registered or inlineCallbacks syntax.

[fss, 2012-11-22 13:58:26]

https://codereview.appspot.com/6850044/diff/7017/juju/providers/ec2/securityg...
File juju/providers/ec2/securitygroup.py (right):

https://codereview.appspot.com/6850044/diff/7017/juju/providers/ec2/securityg...
juju/providers/ec2/securitygroup.py:11: for group in d.result:
On 2012/11/22 13:44:07, hazmat wrote:
> This is very suspect, deferred results should not be access directly, this
needs
> a callback registered or inlineCallbacks syntax.

Thanks, I will fix this.

I will also stop updating this CL using lbox, so you guys stop receiving
notifications. There is more than VPC in this CL now (proxy, pre-installed juju,
etc.), and we will probably keep using this fork. I hope that we will be able to
send smaller patchs for merging in the (near) future.

[hazmat, 2012-11-22 14:26:33]

no worries about using lbox, i don't mind having a look on occasion, i
understood from the merge proposal that it wasn't intended for merge. i've
been going through the txaws branches as well, which look good but i'll
need to rope in one more reviewer for them i think. i'd like to get some
additional functionality there for txaws to be able to create vpc, with a
goal that juju can create the vpc itself.  cheers.

On Thu, Nov 22, 2012 at 8:58 AM, <franciscossouza@gmail.com> wrote:

>
> https://codereview.appspot.**com/6850044/diff/7017/juju/**
>
providers/ec2/securitygroup.py<https://codereview.appspot.com/6850044/diff/7017/juju/providers/ec2/securitygroup.py>
> File juju/providers/ec2/**securitygroup.py (right):
>
> https://codereview.appspot.**com/6850044/diff/7017/juju/**
>
providers/ec2/securitygroup.**py#newcode11<https://codereview.appspot.com/6850044/diff/7017/juju/providers/ec2/securitygroup.py#newcode11>
> juju/providers/ec2/**securitygroup.py:11: for group in d.result:
> On 2012/11/22 13:44:07, hazmat wrote:
>
>> This is very suspect, deferred results should not be access directly,
>>
> this needs
>
>> a callback registered or inlineCallbacks syntax.
>>
>
> Thanks, I will fix this.
>
> I will also stop updating this CL using lbox, so you guys stop receiving
> notifications. There is more than VPC in this CL now (proxy,
> pre-installed juju, etc.), and we will probably keep using this fork. I
> hope that we will be able to send smaller patchs for merging in the
> (near) future.
>
>
https://codereview.appspot.**com/6850044/<https://codereview.appspot.com/6850...
>

[fss, 2012-11-22 15:26:47]

On 2012/11/22 14:26:33, hazmat wrote:
> no worries about using lbox, i don't mind having a look on occasion, i
> understood from the merge proposal that it wasn't intended for merge. i've
> been going through the txaws branches as well, which look good but i'll
> need to rope in one more reviewer for them i think. i'd like to get some
> additional functionality there for txaws to be able to create vpc, with a
> goal that juju can create the vpc itself.  cheers.
 
Indeed. txaws branches are there for merging, I think they're quite there. Are
you able to review and merge them? I'd like to move forward in getting those
branches merged.

Regards,
Francisco

[fss, 2012-11-22 16:06:49]

Please take a look.

https://codereview.appspot.com/6850044/diff/7017/juju/providers/ec2/securityg...
File juju/providers/ec2/securitygroup.py (right):

https://codereview.appspot.com/6850044/diff/7017/juju/providers/ec2/securityg...
juju/providers/ec2/securitygroup.py:11: for group in d.result:
On 2012/11/22 13:44:07, hazmat wrote:
> This is very suspect, deferred results should not be access directly, this
needs
> a callback registered or inlineCallbacks syntax.

Done.

[fss, 2012-11-23 12:52:42]

Please take a look.

[fss, 2012-11-23 14:02:21]

Please take a look.

[fss, 2012-11-23 18:51:53]

Please take a look.

[fss, 2012-11-23 18:56:34]

Please take a look.

[fss, 2012-11-23 19:23:42]

Please take a look.

[fss, 2012-11-23 20:18:08]

Please take a look.

[fss, 2012-11-23 20:59:04]

Please take a look.