Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(54)

Issue 6849132: Modernize vala binding generation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by Daiki Ueno
Modified:
11 years, 11 months ago
Reviewers:
shawn.p.huang
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Modernize vala binding generation Use vapigen.m4 and Makefile.vapigen from vala to handle vapi file generation. Also generate vapi always when gir is updated. BUG=none Committed: 58accdc

Patch Set 1 #

Patch Set 2 : check vala and vapigen version >= 0.16 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -34 lines) Patch
M bindings/Makefile.am View 1 chunk +1 line, -1 line 0 comments Download
M bindings/vala/Makefile.am View 1 chunk +17 lines, -17 lines 0 comments Download
M configure.ac View 1 3 chunks +4 lines, -16 lines 2 comments Download
M m4/Makefile.am View 1 chunk +1 line, -0 lines 0 comments Download
A m4/vapigen.m4 View 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Daiki Ueno
https://live.gnome.org/Vala/UpstreamGuide#Autotools_Integration
11 years, 11 months ago (2012-12-01 08:11:04 UTC) #1
Peng
On 2012/12/01 08:11:04, Daiki Ueno wrote: > https://live.gnome.org/Vala/UpstreamGuide#Autotools_Integration lgtm
11 years, 11 months ago (2012-12-03 13:27:59 UTC) #2
Daiki Ueno
On 2012/12/03 13:27:59, Peng wrote: > On 2012/12/01 08:11:04, Daiki Ueno wrote: > > https://live.gnome.org/Vala/UpstreamGuide#Autotools_Integration ...
11 years, 11 months ago (2012-12-04 03:22:47 UTC) #3
Peng
On 2012/12/04 03:22:47, Daiki Ueno wrote: > On 2012/12/03 13:27:59, Peng wrote: > > On ...
11 years, 11 months ago (2012-12-04 15:46:46 UTC) #4
Peng
https://codereview.appspot.com/6849132/diff/4002/configure.ac File configure.ac (right): https://codereview.appspot.com/6849132/diff/4002/configure.ac#newcode123 configure.ac:123: AM_PROG_VALAC([0.16]) I modified here to 0.14, and generate a ...
11 years, 11 months ago (2012-12-06 19:30:22 UTC) #5
Daiki Ueno
11 years, 11 months ago (2012-12-06 20:52:33 UTC) #6
https://codereview.appspot.com/6849132/diff/4002/configure.ac
File configure.ac (right):

https://codereview.appspot.com/6849132/diff/4002/configure.ac#newcode123
configure.ac:123: AM_PROG_VALAC([0.16])
On 2012/12/06 19:30:22, Peng wrote:
> I modified here to 0.14, and generate a tarball and tested it with vala-0.14.
I
> did not find any problem during building. I guess vala-0.16 is only needed for
> generating configure. Is it right? In that case, I suggest using 0.14 here.

Not exactly, but changing it back to 0.14 should be fine. 

vala-0.16 is needed for generating *.vapi using Makefile.vapgen, which is
available since 0.16.  So be careful when generating tarballs.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b