Issue 6849117: Add auto table ref for coretext.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6849117: Add auto table ref for coretext. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bungeman

Modified:
12 years ago

Reviewers:
caryclark1, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 2 : Add missing ~. #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -105 lines)			Patch
	M	src/ports/SkFontHost_mac_coretext.cpp	View	1	12 chunks	+77 lines, -105 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bungeman

This introduces AutoCGTable as a replacement for AutoCFDataRelease and uses it. It also renames the ...

12 years ago (2012-11-28 23:51:20 UTC) #1

reed1

https://codereview.appspot.com/6849117/diff/1/src/ports/SkFontHost_mac_coretext.cpp File src/ports/SkFontHost_mac_coretext.cpp (right): https://codereview.appspot.com/6849117/diff/1/src/ports/SkFontHost_mac_coretext.cpp#newcode67 src/ports/SkFontHost_mac_coretext.cpp:67: { } Do you mean ~AutoCGTable ?

12 years ago (2012-11-29 12:43:11 UTC) #3

bungeman

12 years ago (2012-11-30 15:04:58 UTC) #4

Message was sent while issue was closed.

Committed revision 6634.

Expand All Messages | Collapse All Messages