Issue 6849103: check for bad enum use when adding contours

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6849103: check for bad enum use when adding contours (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by reed1

Modified:
11 years, 7 months ago

Reviewers:
caryclark, bsalomon, caryclark1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

check for bad enum use when adding contours Committed: https://code.google.com/p/skia/source/detail?r=6547

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -50 lines)			Patch
M	include/core/SkPath.h	View	4 chunks	+69 lines, -50 lines	0 comments	Download
M	src/core/SkPath.cpp	View	4 chunks	+11 lines, -0 lines	1 comment	Download
M	tests/PathTest.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

caryclark1

11 years, 7 months ago (2012-11-26 18:20:03 UTC) #3

https://codereview.appspot.com/6849103/diff/1/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.appspot.com/6849103/diff/1/src/core/SkPath.cpp#newcode1107
src/core/SkPath.cpp:1107: 
assert missing for SkPath::addCircle()

Expand All Messages | Collapse All Messages