Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1551)

Issue 6849075: Add missing SK_API define. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by tfarina1
Modified:
11 years, 10 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add missing SK_API define. For a detailed explanation of this, please refer to Nico Weber description here: https://chromiumcodereview.appspot.com/10386108 R=bsalomon@google.com Committed: https://code.google.com/p/skia/source/detail?r=6489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M include/core/SkPreConfig.h View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 3
tfarina1
Hi Brian, could you review this to me? Thanks!
11 years, 10 months ago (2012-11-19 01:48:49 UTC) #1
bsalomon
On 2012/11/19 01:48:49, tfarina1 wrote: > Hi Brian, could you review this to me? > ...
11 years, 10 months ago (2012-11-19 13:42:49 UTC) #2
robertphillips
11 years, 10 months ago (2012-11-20 13:34:51 UTC) #3
I reverted this change b.c. it broke the Chrome build. Please see:

http://build.chromium.org/p/tryserver.chromium/builders/win_layout/builds/101...

and

http://build.chromium.org/p/tryserver.chromium/builders/win/builds/37548/step...

Most of the errors I observed revolve around gMapXYProcs; e.g.:

ui.gdi_util.obj : error LNK2001: unresolved external symbol "private: static
void (__cdecl*const * const SkMatrix::gMapXYProcs)(class SkMatrix const
&,float,float,struct SkPoint *)"
(?gMapXYProcs@SkMatrix@@0QBQ6AXABV1@MMPAUSkPoint@@@ZB)

ui.skia_util.obj : error LNK2019: unresolved external symbol "private: static
void (__cdecl*const * const SkMatrix::gMapXYProcs)(class SkMatrix const
&,float,float,struct SkPoint *)"
(?gMapXYProcs@SkMatrix@@0QBQ6AXABV1@MMPAUSkPoint@@@ZB) referenced in function
"public: __thiscall SkFlattenable::SkFlattenable(void)"
(??0SkFlattenable@@QAE@XZ)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b