Issue 6849065: Extract transform_scanline_XXXX functions into transform_scanline.h for code-sharing

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6849065: Extract transform_scanline_XXXX functions into transform_scanline.h for code-sharing (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 10 months ago by epoger

Modified:
11 years, 10 months ago

Reviewers:
Leon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Extract transform_scanline_XXXX functions into transform_scanline.h for code-sharing Committed: https://code.google.com/p/skia/source/detail?r=6468

Patch Set 2 : doxygen_formatting #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -878 lines)			Patch
M	include/images/SkImageEncoder.h	View	1	1 chunk	+27 lines, -3 lines	0 comments	Download
M	src/images/SkImageDecoder_libpng.cpp	View		3 chunks	+2 lines, -94 lines	0 comments	Download
A +	src/images/transform_scanline.h	View	1	6 chunks	+41 lines, -781 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

epoger

I want to use some of these same functions for generating SkBitmap checksums, so I ...

11 years, 10 months ago (2012-11-16 18:13:49 UTC) #1

reed1

lgtm w/ suggestion for comments on public APIs https://codereview.appspot.com/6849065/diff/1/include/images/SkImageEncoder.h File include/images/SkImageEncoder.h (right): https://codereview.appspot.com/6849065/diff/1/include/images/SkImageEncoder.h#newcode30 include/images/SkImageEncoder.h:30: Thanks ...

11 years, 10 months ago (2012-11-16 18:22:17 UTC) #2

epoger

11 years, 10 months ago (2012-11-16 18:43:18 UTC) #3

On 2012/11/16 18:22:17, reed1 wrote:
> lgtm w/ suggestion for comments on public APIs

Good idea.  Done throughout (no reason NOT to, even in the private
transform_scanline.h ...)

Will commit soon.
> 
> https://codereview.appspot.com/6849065/diff/1/include/images/SkImageEncoder.h
> File include/images/SkImageEncoder.h (right):
> 
>
https://codereview.appspot.com/6849065/diff/1/include/images/SkImageEncoder.h...
> include/images/SkImageEncoder.h:30: 
> Thanks for adding dox. If possible, lets use doxygen compatible formatting, so
> they will get scraped. e.g.
> 
> /**
>  * Encode bitmap 'bm' in the desired ...
>  */

Expand All Messages | Collapse All Messages