Issue 6847116: Set empty/wide-open genID on clip stack in more places and fix a bug in GrReduceClipStack.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6847116: Set empty/wide-open genID on clip stack in more places and fix a bug in GrReduceClipStack. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bsalomon

Modified:
12 years ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Set empty/wide-open genID on clip stack in more places and fix a bug in GrReduceClipStack. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6579

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Reenable clip stack reduce test #

Patch Set 4 : Set empty/wide-open genID on clip stack in more places and fix a bug in #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -20 lines)			Patch
M	src/core/SkClipStack.cpp	View	1 2 3	19 chunks	+24 lines, -17 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	1 2 3	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/ClipStackTest.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

Set empty/wide-open genID on clip stack in more places and fix a bug in GrReduceClipStack. ...

12 years ago (2012-11-28 14:41:54 UTC) #3

bsalomon

12 years ago (2012-11-28 14:42:33 UTC) #4

On 2012/11/27 22:43:14, robertphillips wrote:
> LGTM - how did this ever work before?

Yeah I wondered that myself. I guess no where else were we relying on the
Iter::Clip::fGenID being kEmpty when fPath and fRect are both NULL.

Expand All Messages | Collapse All Messages