Issue 6847109: Make the clip stack reduction test generate inverse filled paths.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6847109: Make the clip stack reduction test generate inverse filled paths. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by bsalomon

Modified:
11 years, 7 months ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make the clip stack reduction test generate inverse filled paths. Also adds some comments to GrReduceClipStack. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6561

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Make the clip stack reduction test generate inverse filled paths. #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -20 lines)			Patch
M	include/core/SkRandom.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View	1 2	6 chunks	+18 lines, -4 lines	0 comments	Download
M	tests/ClipStackTest.cpp	View	1 2	4 chunks	+37 lines, -16 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

robertphillips

LGTM + a comment suggestion & what I believe to be a small oversight https://codereview.appspot.com/6847109/diff/2001/tests/ClipStackTest.cpp ...

11 years, 7 months ago (2012-11-27 13:12:37 UTC) #2

bsalomon

https://codereview.appspot.com/6847109/diff/2001/tests/ClipStackTest.cpp File tests/ClipStackTest.cpp (right): https://codereview.appspot.com/6847109/diff/2001/tests/ClipStackTest.cpp#newcode650 tests/ClipStackTest.cpp:650: // Functions that add a shape to the clip ...

11 years, 7 months ago (2012-11-27 15:39:52 UTC) #3

bsalomon

11 years, 7 months ago (2012-11-27 15:43:07 UTC) #4

Make the clip stack reduction test generate inverse filled paths.

Also adds some comments to GrReduceClipStack.

R=robertphillips@google.com

Expand All Messages | Collapse All Messages