Issue 6847046: Update filter tool to allow input directory.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6847046: Update filter tool to allow input directory. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by DerekS

Modified:
11 years, 7 months ago

Reviewers:
robertphillips, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Update filter tool to allow input directory. Committed: https://code.google.com/p/skia/source/detail?r=6399

Patch Set 2 : rebase #

Total comments: 3

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -36 lines)			Patch
	M	gyp/tools.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	tools/filtermain.cpp	View		5 chunks	+82 lines, -36 lines	3 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

robertphillips

LGTM. https://codereview.appspot.com/6847046/diff/2001/tools/filtermain.cpp File tools/filtermain.cpp (right): https://codereview.appspot.com/6847046/diff/2001/tools/filtermain.cpp#newcode23 tools/filtermain.cpp:23: SkDebugf(" -o outFile : result of filtering.\n"); Please ...

11 years, 7 months ago (2012-11-13 18:44:51 UTC) #2

DerekS

11 years, 7 months ago (2012-11-13 18:50:21 UTC) #3

https://codereview.appspot.com/6847046/diff/2001/tools/filtermain.cpp
File tools/filtermain.cpp (right):

https://codereview.appspot.com/6847046/diff/2001/tools/filtermain.cpp#newcode236
tools/filtermain.cpp:236: 
On 2012/11/13 18:44:51, robertphillips wrote:
> What happens if we pass a filename to SkOSFile::Iter? If it just iterates over
> that file we should unify our handling of the path and file.

if passed a file and not a directory the call to iter.next will return false.

Expand All Messages | Collapse All Messages