Issue 6846076: Add support for SkImageRef_ashmem.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6846076: Add support for SkImageRef_ashmem. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by DerekS

Modified:
11 years, 7 months ago

Reviewers:
Leon, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add support for SkImageRef_ashmem. This requires copying the ashmem utility wrapper functions from a private android library into our source tree in order to be NDK compliant. Committed: https://code.google.com/p/skia/source/detail?r=6488

Patch Set 1 #

Patch Set 2 : add ashmem wrapper functions #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+146 lines, -4 lines)			Patch
M	gyp/ports.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/utils.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/ports/SkImageRef_ashmem.cpp	View		2 chunks	+4 lines, -3 lines	0 comments	Download
A	src/utils/android/ashmem.h	View	1	1 chunk	+45 lines, -0 lines	0 comments	Download
A	src/utils/android/ashmem.c	View	1	1 chunk	+91 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

11 years, 7 months ago (2012-11-19 19:28:07 UTC) #3

lgtm

readString() really returns malloc(), and not SkString? wow.

Expand All Messages | Collapse All Messages