Remove gnome-icon-theme-legacy dependency.

Remove gnome-icon-theme-legacy dependency.

gtk_image_set_from_icon_name() accesses the icon_name only but
gtk_image_set_from_stock() can fallback the stock name to the real name.
E.g. "gtk-about.png" is the symlink of "help-about.png" and
"gtk-about.png" is included in gnome-icon-theme-legacy package in Fedora.

[Peng, 2012-11-15 15:40:20]

On 2012/11/15 13:14:14, fujiwara wrote:

[Peng, 2012-11-15 15:40:26]

https://codereview.appspot.com/6846058/diff/1/setup/engineabout.py
File setup/engineabout.py (left):

https://codereview.appspot.com/6846058/diff/1/setup/engineabout.py#oldcode41
setup/engineabout.py:41: self.set_icon_name(Gtk.STOCK_ABOUT)
I think using 'help-about' should be enough. I found stock_id is not equal to
icon name. so we should not use stock_id here.

https://codereview.appspot.com/6846058/diff/1/setup/enginecombobox.py
File setup/enginecombobox.py (right):

https://codereview.appspot.com/6846058/diff/1/setup/enginecombobox.py#newcode122
setup/enginecombobox.py:122: pixbuf = load_icon(Gtk.STOCK_MISSING_IMAGE,
I think it is better use 'image-missing' here directly.

https://codereview.appspot.com/6846058/diff/1/setup/enginetreeview.py
File setup/enginetreeview.py (right):

https://codereview.appspot.com/6846058/diff/1/setup/enginetreeview.py#newcode125
setup/enginetreeview.py:125: pixbuf = load_icon(Gtk.STOCK_MISSING_IMAGE,
ditto

https://codereview.appspot.com/6846058/diff/1/setup/icon.py
File setup/icon.py (right):

https://codereview.appspot.com/6846058/diff/1/setup/icon.py#newcode40
setup/icon.py:40: def load_icon(icon, size, fallback_icon=None):
Please rename icon to icon_name_or_path. So the caller should not pass stock_id
in.

And is there any case caller does not pass fallback_icon with 'missing'? If not,
I suggest remove it, and return 'missing' icon, if can not load icon
successfully.

https://codereview.appspot.com/6846058/diff/1/ui/gtk3/iconwidget.vala
File ui/gtk3/iconwidget.vala (right):

https://codereview.appspot.com/6846058/diff/1/ui/gtk3/iconwidget.vala#newcode24
ui/gtk3/iconwidget.vala:24: public IconWidget(string icon, Gtk.IconSize size) {
same , rename icon to icon_name or path. And then it will not accept stock_id
anymore.

https://codereview.appspot.com/6846058/diff/1/ui/gtk3/switcher.vala
File ui/gtk3/switcher.vala (right):

https://codereview.appspot.com/6846058/diff/1/ui/gtk3/switcher.vala#newcode38
ui/gtk3/switcher.vala:38: IconWidget icon = new IconWidget(engine.get_icon(),
Gtk.IconSize.DIALOG);
This line is more than 80.

[fujiwara, 2012-11-16 09:50:11]

On 2012/11/15 15:40:26, Peng wrote:
> https://codereview.appspot.com/6846058/diff/1/setup/engineabout.py
> File setup/engineabout.py (left):
> 
> https://codereview.appspot.com/6846058/diff/1/setup/engineabout.py#oldcode41
> setup/engineabout.py:41: self.set_icon_name(Gtk.STOCK_ABOUT)
> I think using 'help-about' should be enough. I found stock_id is not equal to
> icon name. so we should not use stock_id here.
> 
> https://codereview.appspot.com/6846058/diff/1/setup/enginecombobox.py
> File setup/enginecombobox.py (right):
> 
>
https://codereview.appspot.com/6846058/diff/1/setup/enginecombobox.py#newcode122
> setup/enginecombobox.py:122: pixbuf = load_icon(Gtk.STOCK_MISSING_IMAGE,
> I think it is better use 'image-missing' here directly.
> 
> https://codereview.appspot.com/6846058/diff/1/setup/enginetreeview.py
> File setup/enginetreeview.py (right):
> 
>
https://codereview.appspot.com/6846058/diff/1/setup/enginetreeview.py#newcode125
> setup/enginetreeview.py:125: pixbuf = load_icon(Gtk.STOCK_MISSING_IMAGE,
> ditto
> 
> https://codereview.appspot.com/6846058/diff/1/setup/icon.py
> File setup/icon.py (right):
> 
> https://codereview.appspot.com/6846058/diff/1/setup/icon.py#newcode40
> setup/icon.py:40: def load_icon(icon, size, fallback_icon=None):
> Please rename icon to icon_name_or_path. So the caller should not pass
stock_id
> in.
> 
> And is there any case caller does not pass fallback_icon with 'missing'? If
not,
> I suggest remove it, and return 'missing' icon, if can not load icon
> successfully.

OK, I updated the patch.
I think some desktops do not need both gnome-icon-theme and
gnome-icon-theme-legacy but they may provide the stock ids with a special way:
http://code.google.com/p/ibus/issues/detail?id=1114
But I think 'ibus-engine' icon can be detected in the most case here so I
changed the stock id to 'image-missing'.

> 
> https://codereview.appspot.com/6846058/diff/1/ui/gtk3/iconwidget.vala
> File ui/gtk3/iconwidget.vala (right):
> 
>
https://codereview.appspot.com/6846058/diff/1/ui/gtk3/iconwidget.vala#newcode24
> ui/gtk3/iconwidget.vala:24: public IconWidget(string icon, Gtk.IconSize size)
{
> same , rename icon to icon_name or path. And then it will not accept stock_id
> anymore.
> 
> https://codereview.appspot.com/6846058/diff/1/ui/gtk3/switcher.vala
> File ui/gtk3/switcher.vala (right):
> 
> https://codereview.appspot.com/6846058/diff/1/ui/gtk3/switcher.vala#newcode38
> ui/gtk3/switcher.vala:38: IconWidget icon = new IconWidget(engine.get_icon(),
> Gtk.IconSize.DIALOG);
> This line is more than 80.

[Peng, 2012-11-22 02:50:33]

lgtm.