Turn on the separable blur (release the hounds!). This will require rebaselines of the following S…

Turn on the separable blur (release the hounds!).  This will require rebaselines of the following Skia tests:  tilemodes, texteffects, shadows, drawlooper, drawbitmaprect, circles, blurrect_grad, blurrect, blurs, drawbitmapmatrix (max. pixel change in 8888 is 5).

NOTE:  This will require adding SK_DISABLE_SEPARABLE_MASK_BLUR to skia.gyp on the next roll into Chrome, until the Chrome rebaselines are done.

Committed: https://code.google.com/p/skia/source/detail?r=6606

[Stephen White, 2012-11-29 18:00:24]

PTAL

[reed1, 2012-11-29 18:09:00]

Awecome!

can we change this to

SK_DISABLE_SEPARABLE_BLUR

in the C code, and then we'll add that to skia.gyp on our next roll? That more
closely matches our rebaselining pattern.

[Stephen White, 2012-11-29 18:13:44]

On 2012/11/29 18:09:00, reed1 wrote:
> Awecome!
> 
> can we change this to
> 
> SK_DISABLE_SEPARABLE_BLUR
> 
> in the C code, and then we'll add that to skia.gyp on our next roll? That more
> closely matches our rebaselining pattern.

Done.

[reed1, 2012-11-29 18:47:42]

lgtm -- lets hope our bots cooperate w/ the rebaselining

[robertphillips, 2012-11-29 19:33:33]

Just to make sure. I am adding SK_DISABLE_SEPARABLE_BLUR to Chrome's
skia.gyp in tomorrow's roll - right?

On Thu, Nov 29, 2012 at 1:47 PM, <reed@google.com> wrote:

> lgtm -- lets hope our bots cooperate w/ the rebaselining
>
>
>
https://codereview.appspot.**com/6845111/<https://codereview.appspot.com/6845...
>
> --
> You received this message because you are subscribed to the Google Groups
> "skia-review" group.
> To post to this group, send email to skia-review@googlegroups.com.
> To unsubscribe from this group, send email to skia-review+unsubscribe@**
> googlegroups.com <skia-review%2Bunsubscribe@googlegroups.com>.
> For more options, visit this group at http://groups.google.com/**
> group/skia-review?hl=en <http://groups.google.com/group/skia-review?hl=en>
> .
>
>

[reed1, 2012-11-29 19:41:48]

Only if you need to :)

On Thu, Nov 29, 2012 at 1:54 PM, Robert Phillips
<robertphillips@google.com>wrote:

> Just to make sure. I am adding SK_DISABLE_SEPARABLE_BLUR to Chrome's
> skia.gyp in tomorrow's roll - right?
>
> On Thu, Nov 29, 2012 at 1:47 PM, <reed@google.com> wrote:
>
>>  lgtm -- lets hope our bots cooperate w/ the rebaselining
>>
>>
>>
https://codereview.appspot.**com/6845111/<https://codereview.appspot.com/6845...
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "skia-review" group.
>> To post to this group, send email to skia-review@googlegroups.com.
>> To unsubscribe from this group, send email to skia-review+unsubscribe@**
>> googlegroups.com <skia-review%2Bunsubscribe@googlegroups.com>.
>> For more options, visit this group at http://groups.google.com/**
>> group/skia-review?hl=en<http://groups.google.com/group/skia-review?hl=en>
>> .
>>
>>
>  --
> You received this message because you are subscribed to the Google Groups
> "skia-review" group.
> To post to this group, send email to skia-review@googlegroups.com.
> To unsubscribe from this group, send email to
> skia-review+unsubscribe@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/skia-review?hl=en.
>