Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 6845062: code review 6845062: net: remove another unguarded sysfile == nil check (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 6 months ago by dfc
Modified:
2 years, 6 months ago
Reviewers:
CC:
mikio, dvyukov, golang-dev
Visibility:
Public.

Description

net: remove another unguarded sysfile == nil check Putting aside the unguarded access to fd.sysfile, the condition will never be true as fd.incref above handles the closed condition.

Patch Set 1 #

Patch Set 2 : diff -r 852ee39cc8c4 https://code.google.com/p/go #

Patch Set 3 : diff -r 852ee39cc8c4 https://code.google.com/p/go #

Patch Set 4 : diff -r 1315abc581ed https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M src/pkg/net/fd_unix.go View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4
dfc
Hello mikioh.mikioh@gmail.com, dvyukov@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
2 years, 6 months ago (2012-11-20 10:06:02 UTC) #1
dvyukov
LGTM
2 years, 6 months ago (2012-11-20 14:50:30 UTC) #2
mikio
LGTM
2 years, 6 months ago (2012-11-20 23:19:55 UTC) #3
dfc
2 years, 6 months ago (2012-11-21 04:04:40 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=2a55e349097f ***

net: remove another unguarded sysfile == nil check

Putting aside the unguarded access to fd.sysfile, the condition will never be
true as fd.incref above handles the closed condition.

R=mikioh.mikioh, dvyukov
CC=golang-dev
http://codereview.appspot.com/6845062
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e6eadc5