src/cmd/8g/cgen.c - Issue 6845053: code review 6845053: cmd/8g: fix erroneous LEAL nil.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/8g/cgen.c

Issue 6845053: code review 6845053: cmd/8g: fix erroneous LEAL nil. (Closed)

Patch Set: diff -r 2a55e349097f https://go.googlecode.com/hg/ Created 12 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/8g/cgen.c

===================================================================

--- a/src/cmd/8g/cgen.c

+++ b/src/cmd/8g/cgen.c

@@ -827,16 +827,19 @@

return;

case ODOTPTR:

- if(n->left->addable

- || n->left->op == OCALLFUNC

- || n->left->op == OCALLMETH

- || n->left->op == OCALLINTER) {

+ switch(n->left->op) {

+ case ODOT:

+ case ODOTPTR:

+ case OCALLFUNC:

+ case OCALLMETH:

+ case OCALLINTER:

// igen-able nodes.

igen(n->left, &n1, res);

regalloc(a, types[tptr], &n1);

gmove(&n1, a);

regfree(&n1);

- } else {

+ break;

+ default:

regalloc(a, types[tptr], res);

cgen(n->left, a);

}

« no previous file with comments | « no previous file | src/cmd/8g/gsubr.c » ('j') | no next file with comments »